This will likely be necessary for jump to location to work as expected with minified code in the Scripts timeline.
Moving to the right component.
This certainly works now.
Oh, just kidding. But we only use these instrumentations in the overview afaik.
Created attachment 358715 [details]
Attachment 358715 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:9: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] 
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 358715 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=358715&action=review
We don't have any tests on Timeline events right now, we should tackle that at some point.
> + No new tests (OOPS!).
Seems we can have a test.
> -Ref<JSON::Object> TimelineRecordFactory::createEvaluateScriptData(const String& url, double lineNumber)
> +Ref<JSON::Object> TimelineRecordFactory::createEvaluateScriptData(const String& url, double lineNumber, double columnNumber)
Hmm, why are these doubles? Maybe we can convert them to ints up the chain. JSON::Object::setInteger implicitly converts it to an int anyways.
Created attachment 359835 [details]
Comment on attachment 359835 [details]
Clearing flags on attachment: 359835
Committed r240323: <https://trac.webkit.org/changeset/240323>
All reviewed patches have been landed. Closing bug.