Bug 116180 - [Mac] media engine may deliver NULL in-band "cue"
Summary: [Mac] media engine may deliver NULL in-band "cue"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-15 12:46 PDT by Eric Carlson
Modified: 2013-05-15 15:38 PDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (1.54 KB, patch)
2013-05-15 12:54 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-05-15 12:46:35 PDT
r145326 add a NULL check to InbandTextTrackPrivateAVF::processCue, but the debug-only logging added in r149187 is before the NULL check so it will crash when a NULL "cue" is delivered by the media engine.
Comment 1 Radar WebKit Bug Importer 2013-05-15 12:48:39 PDT
<rdar://problem/13902910>
Comment 2 Eric Carlson 2013-05-15 12:54:27 PDT
Created attachment 201870 [details]
Proposed patch
Comment 3 Jer Noble 2013-05-15 12:56:17 PDT
Comment on attachment 201870 [details]
Proposed patch

Yay null checks!
Comment 4 WebKit Commit Bot 2013-05-15 15:38:21 PDT
Comment on attachment 201870 [details]
Proposed patch

Clearing flags on attachment: 201870

Committed r150153: <http://trac.webkit.org/changeset/150153>
Comment 5 WebKit Commit Bot 2013-05-15 15:38:23 PDT
All reviewed patches have been landed.  Closing bug.