Bug 116172 - Avoid backing store for the WebFrameView's layer when the WebView is layer-backed
Summary: Avoid backing store for the WebFrameView's layer when the WebView is layer-ba...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 116171 (view as bug list)
Depends on: 116214
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-15 11:24 PDT by Simon Fraser (smfr)
Modified: 2013-05-16 11:40 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.62 KB, patch)
2013-05-15 11:29 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-05-15 11:24:45 PDT 
Avoid backing store for the WebFrameView's layer when the WebView is layer-backed
Comment 1 Simon Fraser (smfr) 2013-05-15 11:29:01 PDT 
Created attachment 201859 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-05-15 11:29:52 PDT 
*** Bug 116171 has been marked as a duplicate of this bug. ***
Comment 3 Simon Fraser (smfr) 2013-05-15 11:30:48 PDT 
<rdar://problem/13741243>
Comment 4 Tim Horton 2013-05-15 11:33:24 PDT 
Comment on attachment 201859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201859&action=review

> Source/WebKit/mac/WebView/WebFrameView.mm:82
> +@interface NSView (AppKitSecretsIKnow)

(Details)

> Source/WebKit/mac/WebView/WebFrameView.mm:490
> +    if ([self documentView] == nil) {

"comparison with nil/0/etc" la la la stylebot
Comment 5 Simon Fraser (smfr) 2013-05-15 19:05:05 PDT 
r150168
Comment 6 WebKit Commit Bot 2013-05-16 02:59:59 PDT 
Re-opened since this is blocked by bug 116214
Comment 7 Tim Horton 2013-05-16 03:00:22 PDT 
-[WebFrameView setBackgroundColor:]: unrecognized selector sent to instance 0x7f9cc5d64c50
Comment 8 Simon Fraser (smfr) 2013-05-16 09:00:40 PDT 
Boo.
Comment 9 Simon Fraser (smfr) 2013-05-16 11:32:46 PDT 
That only happened with the 1Password extension installed, which is why I didn't see it.
Comment 10 Simon Fraser (smfr) 2013-05-16 11:40:08 PDT 
Re-landed in https://trac.webkit.org/r150194