Bug 116166 - [Mac] Make Clipboard class no longer polymorphic by removing the last virtual functions
Summary: [Mac] Make Clipboard class no longer polymorphic by removing the last virtual...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 115980
  Show dependency treegraph
 
Reported: 2013-05-15 10:25 PDT by Darin Adler
Modified: 2013-05-15 12:37 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.45 KB, patch)
2013-05-15 10:29 PDT, Darin Adler
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-05-15 10:25:14 PDT
[Mac] Make Clipboard class no longer polymorphic by removing the last virtual functions
Comment 1 Darin Adler 2013-05-15 10:29:04 PDT
Created attachment 201854 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-05-15 11:44:56 PDT
Comment on attachment 201854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201854&action=review

Does the improvement from making a few functions non-virtual outweigh the confusion from them being different across ports?

> Source/WebCore/dom/Clipboard.h:72
> -        virtual ~Clipboard();
> +        LEGACY_VIRTUAL ~Clipboard();

I'm not sure that LEGACY_VIRTUAL is a great name, I certainly wouldn't understand it if I saw it.
Comment 3 Alexey Proskuryakov 2013-05-15 11:45:10 PDT
(I also said r+ with my comment).
Comment 4 Darin Adler 2013-05-15 12:37:23 PDT
Committed r150138: <http://trac.webkit.org/changeset/150138>