Bug 116164 - [BlackBerry] When HTTP auth fails, only purge credentials that match the failed credentials
Summary: [BlackBerry] When HTTP auth fails, only purge credentials that match the fail...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Joe Mason
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-15 10:12 PDT by Joe Mason
Modified: 2013-05-15 14:23 PDT (History)
1 user (show)

See Also:

Attachments
fix (4.92 KB, patch)
2013-05-15 10:18 PDT, Joe Mason 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Mason 2013-05-15 10:12:21 PDT 
When there are multiple HTTP requests in flight with the same bad credentials (common with
    proxy auth if the user mistyped their password), the first 407 that's received will cause
    the credentials to be purged and the password dialog to open for new credentials. This means
    that all 407's received after this should only purge the credentials if they have not
    already been updated from the dialog; otherwise they will be wiping out credentials that
    haven't failed yet.
Comment 1 Joe Mason 2013-05-15 10:18:10 PDT 
Created attachment 201852 [details]
fix
Comment 2 Rob Buis 2013-05-15 11:20:02 PDT 
Comment on attachment 201852 [details]
fix

Looks good.
Comment 3 WebKit Commit Bot 2013-05-15 14:23:21 PDT 
Comment on attachment 201852 [details]
fix

Clearing flags on attachment: 201852

Committed r150147: <http://trac.webkit.org/changeset/150147>
Comment 4 WebKit Commit Bot 2013-05-15 14:23:23 PDT 
All reviewed patches have been landed.  Closing bug.