Bug 116154 - [GTK] WebAudio doesn't build in WebKitGTK+ 2.0.2
Summary: [GTK] WebAudio doesn't build in WebKitGTK+ 2.0.2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-15 08:04 PDT by Alberto Garcia
Modified: 2013-05-16 13:30 PDT (History)
4 users (show)

See Also:


Attachments
Patch (952 bytes, patch)
2013-05-15 08:32 PDT, Alberto Garcia
no flags Details | Formatted Diff | Diff
Patch (1.06 KB, patch)
2013-05-15 08:33 PDT, Alberto Garcia
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-05-15 08:04:31 PDT
I get .libs/libwebkitgtk-3.0.so: undefined reference to `WebCore::VectorMath::vsmul(float const*, int, float const*, float*, int, unsigned long)'

The problem is that the value of ENABLE_WEB_AUDIO from configure is overriden in Source/autotools/SetupWebKitFeatures.m4

diff --git a/Source/autotools/SetupWebKitFeatures.m4 b/Source/autotools/SetupWebKitFeatures.m4
index 5d59b6e..a2a7c45 100644
--- a/Source/autotools/SetupWebKitFeatures.m4
+++ b/Source/autotools/SetupWebKitFeatures.m4
@@ -171,7 +171,6 @@ $srcdir/Tools/gtk/generate-feature-defines-files $CONFIGURABLE_FEATURE_DEFINES \
        ENABLE_USER_TIMING=0 \
        ENABLE_VIBRATION=0 \
        ENABLE_VIDEO_TRACK=0 \
-       ENABLE_WEB_AUDIO=0 \
        ENABLE_WEB_SOCKETS=1 \
        ENABLE_WEB_TIMING=1 \
        ENABLE_WORKERS=1 \

This was fixed indirectly in master for bug 113349.
Comment 1 Zan Dobersek 2013-05-15 08:18:33 PDT
Unfortunate.

Will you be able to provide the patch?
Comment 2 Alberto Garcia 2013-05-15 08:32:28 PDT
Created attachment 201835 [details]
Patch
Comment 3 Alberto Garcia 2013-05-15 08:33:18 PDT
Created attachment 201836 [details]
Patch
Comment 4 Martin Robinson 2013-05-15 10:46:29 PDT
I'm a bit confused. You say this was fixed in master for https://bugs.webkit.org/show_bug.cgi?id=113349, but https://bugs.webkit.org/show_bug.cgi?id=113349 was merged into 2.0.1.
Comment 5 Alberto Garcia 2013-05-15 11:03:42 PDT
(In reply to comment #4)
> I'm a bit confused. You say this was fixed in master for
> https://bugs.webkit.org/show_bug.cgi?id=113349, but
> https://bugs.webkit.org/show_bug.cgi?id=113349 was merged into
> 2.0.1.

I've just checked the commit in 2.0.1, it kept the ENABLE_WEB_AUDIO=0
line intact.

See line 174 of

http://trac.webkit.org/changeset/148428/releases/WebKitGTK/webkit-2.0/Source/autotools/SetupWebKitFeatures.m4

Compare it with the commit in master:

http://trac.webkit.org/changeset/147967/trunk/Source/autotools/SetupWebKitFeatures.m4
Comment 6 Alberto Garcia 2013-05-16 00:50:23 PDT
You can see the problem easily by running configure --enable-web-audio and checking the value of ENABLE_WEB_AUDIO in WebKitFeatures.h
Comment 7 Gustavo Noronha (kov) 2013-05-16 10:24:07 PDT
I took the liberty of landing this to the stable branch: http://trac.webkit.org/changeset/150185
Comment 8 Alberto Garcia 2013-05-16 13:30:32 PDT
(In reply to comment #7)
> I took the liberty of landing this to the stable branch:

Great, thanks

I think bug 115612 and bug 116227 are also worthwhile. I believe with
these all three we can make a full parallel build with all features
enabled.