WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
116152
[curl] Remove version #if guards
https://bugs.webkit.org/show_bug.cgi?id=116152
Summary
[curl] Remove version #if guards
Peter Gal
Reported
2013-05-15 07:17:40 PDT
There are a few #ifdefs in the curl codeparts to guard for the version > 7.18.0 (which was released in 2008). I think it's time to remove them no one should use such old curl version.
Attachments
version check removal
(4.13 KB, patch)
2013-05-15 07:22 PDT
,
Peter Gal
no flags
Details
Formatted Diff
Diff
fixed bug's name
(4.14 KB, patch)
2013-05-15 07:23 PDT
,
Peter Gal
no flags
Details
Formatted Diff
Diff
try again
(4.13 KB, patch)
2013-05-15 07:25 PDT
,
Peter Gal
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Peter Gal
Comment 1
2013-05-15 07:22:05 PDT
Created
attachment 201826
[details]
version check removal This patch should remove all LIBCURL_VERSION_NUM related #if guards.
Peter Gal
Comment 2
2013-05-15 07:23:52 PDT
Created
attachment 201827
[details]
fixed bug's name
Peter Gal
Comment 3
2013-05-15 07:25:25 PDT
Created
attachment 201828
[details]
try again And again the bug's name is incorrect fixed the changelog. so.. this isn't my day it seems (sorry for the noise)
Brent Fulgham
Comment 4
2013-05-15 08:09:12 PDT
Comment on
attachment 201828
[details]
try again Looks good to me. R=me.
WebKit Commit Bot
Comment 5
2013-05-15 09:21:42 PDT
Comment on
attachment 201828
[details]
try again Clearing flags on attachment: 201828 Committed
r150118
: <
http://trac.webkit.org/changeset/150118
>
WebKit Commit Bot
Comment 6
2013-05-15 09:21:44 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug