Bug 116152 - [curl] Remove version #if guards
Summary: [curl] Remove version #if guards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-15 07:17 PDT by Peter Gal
Modified: 2013-05-15 09:21 PDT (History)
2 users (show)

See Also:

Attachments
version check removal (4.13 KB, patch)
2013-05-15 07:22 PDT, Peter Gal 		no flags Details | Formatted Diff | Diff
fixed bug's name (4.14 KB, patch)
2013-05-15 07:23 PDT, Peter Gal 		no flags Details | Formatted Diff | Diff
try again (4.13 KB, patch)
2013-05-15 07:25 PDT, Peter Gal 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Gal 2013-05-15 07:17:40 PDT 
There are a few #ifdefs in the curl codeparts to guard for the version > 7.18.0 (which was released in 2008). I think it's time to remove them no one should use such old curl version.
Comment 1 Peter Gal 2013-05-15 07:22:05 PDT 
Created attachment 201826 [details]
version check removal

This patch should remove all LIBCURL_VERSION_NUM related #if guards.
Comment 2 Peter Gal 2013-05-15 07:23:52 PDT 
Created attachment 201827 [details]
fixed bug's name
Comment 3 Peter Gal 2013-05-15 07:25:25 PDT 
Created attachment 201828 [details]
try again

And again the bug's name is incorrect fixed the changelog.
so.. this isn't my day it seems (sorry for the noise)
Comment 4 Brent Fulgham 2013-05-15 08:09:12 PDT 
Comment on attachment 201828 [details]
try again

Looks good to me. R=me.
Comment 5 WebKit Commit Bot 2013-05-15 09:21:42 PDT 
Comment on attachment 201828 [details]
try again

Clearing flags on attachment: 201828

Committed r150118: <http://trac.webkit.org/changeset/150118>
Comment 6 WebKit Commit Bot 2013-05-15 09:21:44 PDT 
All reviewed patches have been landed.  Closing bug.