Bug 116122 – [Mac] Add a testing shim for secure event input functions

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

Secure event input is set per user session. When running tests, we should not change it, or depend on it.

[Alexey Proskuryakov]

Created attachment 201755 [details]
proposed patch

[Mark Rowe (bdash)]

Comment on attachment 201755 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201755&action=review

r=me, with several comments.

> Source/WebCore/Configurations/WebCoreTestShim.xcconfig:24
> +#include "WebCore.xcconfig"

What settings from WebCore.xcconfig does this need? Can they be moved to Base.xcconfig instead so we don't have to reset a bunch of things below?

> Source/WebCore/Configurations/WebCoreTestShim.xcconfig:29
> +PRIVATE_HEADERS_FOLDER_PATH = $(PRIVATE_HEADERS_FOLDER_PATH_$(CONFIGURATION));
> +PRIVATE_HEADERS_FOLDER_PATH_Debug = WebCoreTestShim;
> +PRIVATE_HEADERS_FOLDER_PATH_Release = $(PRIVATE_HEADERS_FOLDER_PATH_Debug);
> +PRIVATE_HEADERS_FOLDER_PATH_Production = /usr/local/include/WebCoreTestShim;

I wouldn't expect a shim to need to install headers. Can these simply be removed?

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:27347
> +				PRODUCT_NAME = WebCoreTestShim;

This is set in the .xcconfig file so I think it's redundant to include in the project too.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:27355
> +				PRODUCT_NAME = WebCoreTestShim;

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:27363
> +				PRODUCT_NAME = WebCoreTestShim;

Ditto.

> Source/WebCore/platform/mac/DyldInterpose.h:26
> +#ifndef DyldInterpose_h

Ugh, seeing dyld with this capitalization rubs me the wrong way. Can we use this opportunity to rename it to something without dyld in the name to avoid this problem, like DynamicLinkerInterposing.h?

> Source/WebKit2/PluginProcess/mac/PluginProcessShim.mm:-29
> -#import "DYLDInterpose.h"

I wonder how this ever built on case-sensitive filesystems?

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r150089>.

[Csaba Osztrogonác]

(In reply to comment #3)
> Committed <http://trac.webkit.org/r150089>.

It broke a webkitpy unit test on the bots:

  Traceback (most recent call last):
    File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/port/mac_unittest.py", line 119, in test_setup_environ_for_server
      self.assertEqual(env['DYLD_INSERT_LIBRARIES'], '/usr/lib/libgmalloc.dylib')
  AssertionError: '/usr/lib/libgmalloc.dylib:/mock-build/libWebCoreTestShim.dylib' != '/usr/lib/libgmalloc.dylib'
  
[617/1456] webkitpy.common.checkout.checkout_unittest.CommitMessageForThisCommitTest.test_commit_message_for_this_commit (+11)         

Could you fix it, please?

[Alexey Proskuryakov]

Zan just fixed in <http://trac.webkit.org/changeset/150116>. Sorry for the breakage.