Bug 116117 - Flexbox preferred logical width computation algorithm incorrectly ignores flex-basis
Summary: Flexbox preferred logical width computation algorithm incorrectly ignores fle...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-14 12:35 PDT by Dave Hyatt
Modified: 2022-08-17 20:01 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2013-05-14 12:35:24 PDT
The preferred logical widths algorithm for flexbox needs to take flex-basis into account. Note it can't do that, though, until the spec changes to make 0 not be the default or content will break.
Comment 1 Ryan Reno 2022-08-17 12:13:37 PDT
The algorithm has changed since this bug was created. See:

https://crbug.com/240765
https://github.com/w3c/csswg-drafts/issues/7189

I haven't read the spec closely yet nor that issue thread but I suspect this bug will be resolved by implementing the new spec text for the main axis width algorithm.
Comment 2 Radar WebKit Bug Importer 2022-08-17 12:14:05 PDT
<rdar://problem/98793922>
Comment 3 Ryan Reno 2022-08-17 12:17:14 PDT
WPT failures:
https://wpt.fyi/results/css/css-flexbox/intrinsic-size?label=experimental&label=master&aligned

We're only passing 2 of these tests.
Also need to do a WPT sync as there are more tests than we have in tree.
Comment 4 Ryan Reno 2022-08-17 20:01:24 PDT
WPT sync landed in https://commits.webkit.org/253547@main

So now there's a target to hit.