WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
UNCONFIRMED
116100
Media element shadow tree should reset style inheritance
https://bugs.webkit.org/show_bug.cgi?id=116100
Summary
Media element shadow tree should reset style inheritance
Antoine Quint
Reported
2013-05-14 05:19:00 PDT
In order for styles coming from the page to not affect the content displayed in a media element's shadow root, we need to reset style inheritance. This way only styles defined by the injected user-agent stylesheets will affect the rendering of the shadow content, such as media controls.
Attachments
Patch
(1.49 KB, patch)
2013-05-14 05:21 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
(579.57 KB, application/zip)
2013-05-14 07:06 PDT
,
Build Bot
no flags
Details
Patch
(3.12 KB, patch)
2013-05-14 07:36 PDT
,
Antoine Quint
eric.carlson
: review-
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
(633.49 KB, application/zip)
2013-05-14 08:58 PDT
,
Build Bot
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2013-05-14 05:19:16 PDT
<
rdar://problem/13886140
>
Antoine Quint
Comment 2
2013-05-14 05:21:53 PDT
Created
attachment 201700
[details]
Patch
Build Bot
Comment 3
2013-05-14 07:06:37 PDT
Comment on
attachment 201700
[details]
Patch
Attachment 201700
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/466591
New failing tests: media/controls-styling-strict.html media/video-controls-zoomed.html
Build Bot
Comment 4
2013-05-14 07:06:39 PDT
Created
attachment 201711
[details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Antoine Quint
Comment 5
2013-05-14 07:26:19 PDT
The test at media/controls-styling-strict.html fails without this patch as well on my platform. However, media/video-controls-zoomed.html looks like a new failure indeed.
Antoine Quint
Comment 6
2013-05-14 07:36:28 PDT
Created
attachment 201712
[details]
Patch
Ryosuke Niwa
Comment 7
2013-05-14 08:15:58 PDT
Comment on
attachment 201712
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=201712&action=review
> Source/WebCore/ChangeLog:10 > +
Can we add a test for this?
Build Bot
Comment 8
2013-05-14 08:58:52 PDT
Comment on
attachment 201712
[details]
Patch
Attachment 201712
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/472224
New failing tests: media/controls-styling-strict.html
Build Bot
Comment 9
2013-05-14 08:58:54 PDT
Created
attachment 201721
[details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Eric Carlson
Comment 10
2013-05-14 10:13:55 PDT
Comment on
attachment 201712
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=201712&action=review
> Source/WebCore/ChangeLog:9 > + the rendering of snapshotted plug-ins' shadow content.
"snapshotted plug-ins' shadow content"? :-)
Eric Carlson
Comment 11
2013-05-14 10:26:34 PDT
Comment on
attachment 201712
[details]
Patch Page styles are allowed to affect caption rendering. Can you set inheritance on the portion of the shadow DOM with controls only?
Eric Carlson
Comment 12
2013-08-09 14:31:07 PDT
***
Bug 119637
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug