Bug 116098 – Snapshotted plug-ins shadow tree should reset style inheritance

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Antoine Quint]

In order for styles coming from the page to not affect the content displayed in a snapshotted plug-in's shadow root, we need to reset style inheritance. This way only styles defined by the injected user-agent stylesheets will affect the rendering of the shadow content.

[Antoine Quint]

<rdar://problem/13885342>

[Antoine Quint]

Created attachment 201696 [details]
Patch

[Darin Adler]

Comment on attachment 201696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201696&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:370
> +    root->setResetStyleInheritance(true);

This needs a why comment. It’s not at all clear why this is here or what would break if we removed this, and there’s no regression test to help make it clear.

[Antoine Quint]

(In reply to comment #3)
> (From update of attachment 201696 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201696&action=review
> 
> > Source/WebCore/html/HTMLPlugInImageElement.cpp:370
> > +    root->setResetStyleInheritance(true);
> 
> This needs a why comment. It’s not at all clear why this is here or what would break if we removed this, and there’s no regression test to help make it clear.

Adding a comment in the commit.

[Antoine Quint]

Created attachment 201727 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 201727 [details]
Patch for landing

Clearing flags on attachment: 201727

Committed r150081: <http://trac.webkit.org/changeset/150081>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.