WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
116074
Objective-C API: scanExternalObjectGraph should not create new JSVirtualMachine wrappers
https://bugs.webkit.org/show_bug.cgi?id=116074
Summary
Objective-C API: scanExternalObjectGraph should not create new JSVirtualMachi...
Mark Hahnenberg
Reported
2013-05-13 16:30:47 PDT
If it does, when the scanExternalObjectGraph call finishes and the autorelease pool is drained, we will dealloc the JSVirtualMachine which will cause us to try to take the API lock for the corresponding VM. If this happens on a GC thread other than the "main" thread, we will deadlock. The solution is to just check the VM cache, and if there is no JSVirtualMachine wrapper, return early.
Attachments
Patch
(1.96 KB, patch)
2013-05-13 18:17 PDT
,
Mark Hahnenberg
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2013-05-13 18:17:28 PDT
Created
attachment 201659
[details]
Patch
Mark Hahnenberg
Comment 2
2013-05-13 18:18:15 PDT
<
rdar://problem/13877067
>
Mark Hahnenberg
Comment 3
2013-05-13 19:48:59 PDT
Committed
r150050
: <
http://trac.webkit.org/changeset/150050
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug