RESOLVED FIXED 116066
Do not bloat HTMLTokenizer with a giant inline InputStreamPreprocessor::peek 
https://bugs.webkit.org/show_bug.cgi?id=116066
Summary Do not bloat HTMLTokenizer with a giant inline InputStreamPreprocessor::peek
Ryosuke Niwa
Reported 2013-05-13 15:59:10 PDT
We should probably merge https://chromium.googlesource.com/chromium/blink/+/45e0337b2f2db535ab08365f6e763a5015e4d990 Shrunk HTMLTokenizer.o by 28.2% This CL moves the cold code in InputStreamPreprocessor::peek out-of-line, which shrunks HTMLTokenizer.o on Linux by 28.2%. The CL also makes the html-parser.html performance test faster by 1.3% (average of 15 runs).
Attachments
Patch (3.82 KB, patch)
2013-05-14 19:17 PDT, Benjamin Poulain 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-05-14 09:55:15 PDT
Size of a raw object file is a funny metric - perhaps useful as a tool to discover optimization opportunities, but certainly not a goal in itself :) > html-parser.html performance test faster by 1.3% (average of 15 runs). This is of course more interesting.
Benjamin Poulain
Comment 2 2013-05-14 13:41:57 PDT
(In reply to comment #1) > Size of a raw object file is a funny metric - perhaps useful as a tool to discover optimization opportunities, but certainly not a goal in itself :) We were as confused as you by that claim.
Benjamin Poulain
Comment 3 2013-05-14 13:42:14 PDT
I'll take this one.
Benjamin Poulain
Comment 4 2013-05-14 19:17:39 PDT
Created attachment 201779 [details] Patch
Benjamin Poulain
Comment 5 2013-05-15 01:28:15 PDT
Committed r150105: <http://trac.webkit.org/changeset/150105>
Note You need to log in before you can comment on or make changes to this bug.