WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
116062
Upstream iOS Clipboard and Pasteboard changes
https://bugs.webkit.org/show_bug.cgi?id=116062
Summary
Upstream iOS Clipboard and Pasteboard changes
David Kilzer (:ddkilzer)
Reported
2013-05-13 14:43:24 PDT
Upstream the iOS-specific implementation files for Clipboard and Pasteboard.
Attachments
Patch v1
(47.23 KB, patch)
2013-05-13 14:46 PDT
,
David Kilzer (:ddkilzer)
darin
: review+
ddkilzer
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2013-05-13 14:46:47 PDT
Created
attachment 201635
[details]
Patch v1
Darin Adler
Comment 2
2013-05-13 15:58:38 PDT
Comment on
attachment 201635
[details]
Patch v1 View in context:
https://bugs.webkit.org/attachment.cgi?id=201635&action=review
> Source/WebCore/ChangeLog:11 > + (WebCore):
Normally better to remove lines like this when prepare-ChangeLog adds them.
> Source/WebCore/ChangeLog:16 > + (WebCore): > + (ClipboardIOS): > + (WebCore::ClipboardIOS::create):
I don’t think we need to list the functions for added files. I usually delete them.
> Source/WebCore/ChangeLog:38 > + (WebCore): > + (WebCore::Clipboard::create): > + (WebCore::ClipboardIOS::ClipboardIOS): > + (WebCore::ClipboardIOS::~ClipboardIOS): > + (WebCore::ClipboardIOS::hasData): > + (WebCore::utiTypeFromCocoaType): > + (WebCore::cocoaTypeFromHTMLClipboardType): > + (WebCore::addHTMLClipboardTypesForCocoaType): > + (WebCore::ClipboardIOS::clearData): > + (WebCore::ClipboardIOS::clearAllData): > + (WebCore::ClipboardIOS::getData): > + (WebCore::ClipboardIOS::setData): > + (WebCore::ClipboardIOS::types): > + (WebCore::ClipboardIOS::files): > + (WebCore::ClipboardIOS::writeRange): > + (WebCore::ClipboardIOS::writePlainText): > + (WebCore::ClipboardIOS::writeURL): > + (WebCore::ClipboardIOS::declareAndWriteDragImage): > + (WebCore::ClipboardIOS::createDragImage): > + (WebCore::ClipboardIOS::setDragImage): > + (WebCore::ClipboardIOS::setDragImageElement):
Ditto.
> Source/WebCore/ChangeLog:58 > + (WebCore): > + (WebCore::Pasteboard::generalPasteboard): > + (WebCore::Pasteboard::Pasteboard): > + (WebCore::Pasteboard::clear): > + (WebCore::Pasteboard::getStringSelection): > + (WebCore::Pasteboard::writeSelection): > + (WebCore::Pasteboard::writePlainText): > + (WebCore::Pasteboard::writeImage): > + (WebCore::Pasteboard::writeClipboard): > + (WebCore::Pasteboard::canSmartReplace): > + (WebCore::Pasteboard::plainText): > + (WebCore::supportedImageTypes): > + (WebCore::Pasteboard::supportedPasteboardTypes): > + (WebCore::uniqueURLWithRelativePart): > + (WebCore::documentFragmentWithImageResource): > + (WebCore::documentFragmentWithLink): > + (WebCore::documentFragmentWithRTF): > + (WebCore::Pasteboard::documentFragmentForPasteboardItemAtIndex): > + (WebCore::Pasteboard::documentFragment):
Ditto.
David Kilzer (:ddkilzer)
Comment 3
2013-05-13 19:16:04 PDT
Comment on
attachment 201635
[details]
Patch v1 View in context:
https://bugs.webkit.org/attachment.cgi?id=201635&action=review
>> Source/WebCore/ChangeLog:16 >> + (WebCore::ClipboardIOS::create): > > I don’t think we need to list the functions for added files. I usually delete them.
I actually find this very useful when I'm searching the ChangeLog (or commit log) by function name, but I will delete them.
David Kilzer (:ddkilzer)
Comment 4
2013-05-13 19:21:18 PDT
Committed
r150049
: <
http://trac.webkit.org/changeset/150049
>
David Kilzer (:ddkilzer)
Comment 5
2013-05-13 21:09:26 PDT
(In reply to
comment #4
)
> Committed
r150049
: <
http://trac.webkit.org/changeset/150049
>
Follow-up fix in
r150054
: <
http://trac.webkit.org/changeset/150054
>
Darin Adler
Comment 6
2013-05-14 09:29:26 PDT
(In reply to
comment #3
)
> I actually find this very useful when I'm searching the ChangeLog (or commit log) by function name, but I will delete them.
Really? I also search change log by function name a *lot*, but do you really find it useful to see the check-in where an entire file was added? I haven’t noticed that I do.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug