Bug 116060 - fourthTier: DFG should separate link phase into things that must be done concurrently and things that must be done synchronously, and have a way of passing data from one to the other
Summary: fourthTier: DFG should separate link phase into things that must be done conc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112839
  Show dependency tree / graph
 
Reported: 2013-05-13 14:15 PDT by Filip Pizlo
Modified: 2013-05-15 12:38 PDT (History)
7 users (show)

See Also:

Attachments
work in progress (42.79 KB, patch)
2013-05-13 14:18 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
work in progress (98.32 KB, patch)
2013-05-14 15:29 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (100.08 KB, patch)
2013-05-14 16:49 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (100.48 KB, patch)
2013-05-15 10:22 PDT, Filip Pizlo 		barraclough: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-05-13 14:15:43 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-05-13 14:18:03 PDT 
Created attachment 201633 [details]
work in progress
Comment 2 Filip Pizlo 2013-05-14 15:29:38 PDT 
Created attachment 201765 [details]
work in progress

It seems like it's starting to work.
Comment 3 Filip Pizlo 2013-05-14 16:49:44 PDT 
Created attachment 201771 [details]
the patch
Comment 4 Filip Pizlo 2013-05-15 10:22:40 PDT 
Created attachment 201853 [details]
the patch

Disassembly-related fixes.
Comment 5 Gavin Barraclough 2013-05-15 11:11:11 PDT 
Comment on attachment 201853 [details]
the patch

I buy that Plan can be a struct for now.  I expect that over time we'll want this to be a class, but we'll see. :-)
Might be worth considering making some of the immutable data members const.
Comment 6 Filip Pizlo 2013-05-15 12:33:20 PDT 
(In reply to comment #5)
> (From update of attachment 201853 [details])
> I buy that Plan can be a struct for now.  I expect that over time we'll want this to be a class, but we'll see. :-)
> Might be worth considering making some of the immutable data members const.

Yup, I've made some of the things const!
Comment 7 Filip Pizlo 2013-05-15 12:38:37 PDT 
Landed in http://trac.webkit.org/changeset/150139