Bug 116037 - Frame::editor() should return a reference
Summary: Frame::editor() should return a reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-13 08:49 PDT by Anders Carlsson
Modified: 2013-05-15 13:47 PDT (History)
6 users (show)

See Also:

Attachments
Patch (250.59 KB, patch)
2013-05-13 08:56 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (250.93 KB, patch)
2013-05-15 07:17 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (256.56 KB, patch)
2013-05-15 07:44 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (263.73 KB, patch)
2013-05-15 08:17 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (275.43 KB, patch)
2013-05-15 08:30 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (277.84 KB, patch)
2013-05-15 09:20 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (281.36 KB, patch)
2013-05-15 10:16 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (281.66 KB, patch)
2013-05-15 12:39 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-05-13 08:49:43 PDT 
Frame::editor() should return a reference
Comment 1 Anders Carlsson 2013-05-13 08:56:34 PDT 
Created attachment 201571 [details]
Patch
Comment 2 Darin Adler 2013-05-13 18:23:55 PDT 
Comment on attachment 201571 [details]
Patch

Seems fine. Don’t break everything.
Comment 3 Anders Carlsson 2013-05-15 07:17:31 PDT 
Created attachment 201824 [details]
Patch
Comment 4 Early Warning System Bot 2013-05-15 07:25:42 PDT 
Comment on attachment 201824 [details]
Patch

Attachment 201824 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/468872
Comment 5 Early Warning System Bot 2013-05-15 07:25:49 PDT 
Comment on attachment 201824 [details]
Patch

Attachment 201824 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/479418
Comment 6 EFL EWS Bot 2013-05-15 07:28:29 PDT 
Comment on attachment 201824 [details]
Patch

Attachment 201824 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/479422
Comment 7 EFL EWS Bot 2013-05-15 07:30:39 PDT 
Comment on attachment 201824 [details]
Patch

Attachment 201824 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/472586
Comment 8 kov's GTK+ EWS bot 2013-05-15 07:33:47 PDT 
Comment on attachment 201824 [details]
Patch

Attachment 201824 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/481054
Comment 9 Build Bot 2013-05-15 07:42:28 PDT 
Comment on attachment 201824 [details]
Patch

Attachment 201824 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/472589
Comment 10 Anders Carlsson 2013-05-15 07:44:18 PDT 
Created attachment 201830 [details]
Patch
Comment 11 Early Warning System Bot 2013-05-15 07:51:52 PDT 
Comment on attachment 201830 [details]
Patch

Attachment 201830 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/474522
Comment 12 Early Warning System Bot 2013-05-15 07:52:11 PDT 
Comment on attachment 201830 [details]
Patch

Attachment 201830 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/470550
Comment 13 EFL EWS Bot 2013-05-15 07:58:40 PDT 
Comment on attachment 201830 [details]
Patch

Attachment 201830 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/477472
Comment 14 Build Bot 2013-05-15 08:03:20 PDT 
Comment on attachment 201830 [details]
Patch

Attachment 201830 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/477471
Comment 15 EFL EWS Bot 2013-05-15 08:08:12 PDT 
Comment on attachment 201830 [details]
Patch

Attachment 201830 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/477475
Comment 16 Anders Carlsson 2013-05-15 08:17:06 PDT 
Created attachment 201832 [details]
Patch
Comment 17 EFL EWS Bot 2013-05-15 08:22:46 PDT 
Comment on attachment 201832 [details]
Patch

Attachment 201832 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/468889
Comment 18 EFL EWS Bot 2013-05-15 08:23:54 PDT 
Comment on attachment 201832 [details]
Patch

Attachment 201832 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/477480
Comment 19 Early Warning System Bot 2013-05-15 08:24:30 PDT 
Comment on attachment 201832 [details]
Patch

Attachment 201832 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/467913
Comment 20 Early Warning System Bot 2013-05-15 08:26:02 PDT 
Comment on attachment 201832 [details]
Patch

Attachment 201832 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/477481
Comment 21 Anders Carlsson 2013-05-15 08:30:51 PDT 
Created attachment 201833 [details]
Patch
Comment 22 EFL EWS Bot 2013-05-15 08:36:23 PDT 
Comment on attachment 201833 [details]
Patch

Attachment 201833 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/471596
Comment 23 Build Bot 2013-05-15 08:57:11 PDT 
Comment on attachment 201833 [details]
Patch

Attachment 201833 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/476554
Comment 24 Anders Carlsson 2013-05-15 09:20:26 PDT 
Created attachment 201842 [details]
Patch
Comment 25 Build Bot 2013-05-15 09:49:59 PDT 
Comment on attachment 201842 [details]
Patch

Attachment 201842 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/475553
Comment 26 kov's GTK+ EWS bot 2013-05-15 09:56:53 PDT 
Comment on attachment 201842 [details]
Patch

Attachment 201842 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/480104
Comment 27 Anders Carlsson 2013-05-15 10:16:32 PDT 
Created attachment 201850 [details]
Patch
Comment 28 Anders Carlsson 2013-05-15 12:39:44 PDT 
Created attachment 201865 [details]
Patch
Comment 29 Anders Carlsson 2013-05-15 12:47:29 PDT 
Committed r150140: <http://trac.webkit.org/changeset/150140>