Bug 116036 – [Mac] Move setDragImage from ClipboardMac to PasteboardMac

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Darin Adler]

[Mac] Move setDragImage from ClipboardMac to PasteboardMac

[Darin Adler]

Created attachment 201577 [details]
Patch

[Build Bot]

Comment on attachment 201577 [details]
Patch

Attachment 201577 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/395893

New failing tests:
fast/table/table-rowspan-height-distribution-in-rows.html
fast/events/drag-display-none-element.html
editing/selection/drag-start-event-client-x-y.html
fast/events/clear-drag-state.html
fast/events/drag-and-drop-set-drag-data-arguments.html
fast/events/mousedown-inside-dragstart-should-not-cause-crash.html
editing/pasteboard/drag-and-drop-inputimage-contenteditable.html
fast/events/dragging-mouse-moves.html
fast/events/drag-and-drop-fire-drag-dragover.html
editing/selection/user-drag-element-and-user-select-none.html
fast/css-generated-content/drag-state.html
fast/events/dropzone-003.html
fast/events/remove-target-with-shadow-in-drag.html
fast/events/drag-and-drop-dataTransfer-types-nocrash.html
fast/events/drag-and-drop.html
fast/events/dropzone-002.html
fast/events/bogus-dropEffect-effectAllowed.html
fast/events/dropzone-001.html
editing/pasteboard/drag-and-drop-objectimage-contenteditable.html
fast/css/user-drag-none.html

[Build Bot]

Created attachment 201622 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[Build Bot]

Comment on attachment 201577 [details]
Patch

Attachment 201577 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/470008

New failing tests:
fast/events/clear-drag-state.html
fast/events/drag-and-drop-set-drag-data-arguments.html
fast/events/mousedown-inside-dragstart-should-not-cause-crash.html
fast/events/dragging-mouse-moves.html
editing/selection/user-drag-element-and-user-select-none.html
fast/css-generated-content/drag-state.html
editing/selection/drag-start-event-client-x-y.html
fast/css/user-drag-none.html

[Build Bot]

Created attachment 201657 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[Darin Adler]

Looks like I have some work to do! I had no idea all those dragging tests were failing.

[Darin Adler]

Just one backwards boolean check. Re-uploading shortly.

[Darin Adler]

Created attachment 201783 [details]
Patch

[Anders Carlsson]

Comment on attachment 201783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201783&action=review

> Source/WebCore/dom/Clipboard.cpp:47
> +    void stopLoading(CachedResourceHandle<CachedImage>&);

Missing newline

[Darin Adler]

Committed r150100: <http://trac.webkit.org/changeset/150100>