According to specification [1], BarInfo should be called BarProp and should not have [NoInterfaceObject] extended attribute. Both Firefox and Blink follow the specification. [1] http://www.w3.org/html/wg/drafts/html/master/browsers.html#barprop Corresponding Blink patch: https://src.chromium.org/viewvc/blink?view=rev&revision=150032
Created attachment 201548 [details] Patch
Attachment 201548 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.cpp', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.order', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/gobject/GNUmakefile.am', u'Source/WebCore/page/BarInfo.cpp', u'Source/WebCore/page/BarInfo.h', u'Source/WebCore/page/BarInfo.idl', u'Source/WebCore/page/BarProp.cpp', u'Source/WebCore/page/BarProp.h', u'Source/WebCore/page/BarProp.idl', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/DOMWindow.idl']" exit_code: 1 Source/WebCore/page/DOMWindow.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 201548 [details] Patch Attachment 201548 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/465284
Comment on attachment 201548 [details] Patch Attachment 201548 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/461721
Created attachment 201552 [details] Patch Should fix mac and win builds.
Attachment 201552 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.cpp', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.order', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/gobject/GNUmakefile.am', u'Source/WebCore/page/BarInfo.cpp', u'Source/WebCore/page/BarInfo.h', u'Source/WebCore/page/BarInfo.idl', u'Source/WebCore/page/BarProp.cpp', u'Source/WebCore/page/BarProp.h', u'Source/WebCore/page/BarProp.idl', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/DOMWindow.idl']" exit_code: 1 Source/WebCore/page/DOMWindow.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 201552 [details] Patch r=me!
Comment on attachment 201552 [details] Patch Attachment 201552 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/467174 New failing tests: http/tests/security/cross-frame-access-put.html fast/dom/Window/window-lookup-precedence.html fast/loader/window-properties-restored-from-page-cache.html
Created attachment 201563 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.2
Created attachment 201569 [details] Patch for landing
Attachment 201569 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt', u'LayoutTests/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/fast/loader/window-properties-restored-from-page-cache-expected.txt', u'LayoutTests/http/tests/security/cross-frame-access-put-expected.txt', u'LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.cpp', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.order', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/gobject/GNUmakefile.am', u'Source/WebCore/page/BarInfo.cpp', u'Source/WebCore/page/BarInfo.h', u'Source/WebCore/page/BarInfo.idl', u'Source/WebCore/page/BarProp.cpp', u'Source/WebCore/page/BarProp.h', u'Source/WebCore/page/BarProp.idl', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/DOMWindow.idl']" exit_code: 1 Source/WebCore/page/DOMWindow.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 201630 [details] Patch for landing Update mac specific expectation to make mac-ews happy.
Attachment 201630 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt', u'LayoutTests/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/fast/loader/window-properties-restored-from-page-cache-expected.txt', u'LayoutTests/http/tests/security/cross-frame-access-put-expected.txt', u'LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt', u'LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt', u'LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.cpp', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.order', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/gobject/GNUmakefile.am', u'Source/WebCore/page/BarInfo.cpp', u'Source/WebCore/page/BarInfo.h', u'Source/WebCore/page/BarInfo.idl', u'Source/WebCore/page/BarProp.cpp', u'Source/WebCore/page/BarProp.h', u'Source/WebCore/page/BarProp.idl', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/DOMWindow.idl']" exit_code: 1 Source/WebCore/page/DOMWindow.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 201630 [details] Patch for landing Clearing flags on attachment: 201630 Committed r150045: <http://trac.webkit.org/changeset/150045>
All reviewed patches have been landed. Closing bug.