RESOLVED FIXED 116018
[WK2] PluginInformation.cpp fails to build because of missing ENABLE(NETSCAPE_PLUGIN_API) guard 
https://bugs.webkit.org/show_bug.cgi?id=116018
Summary [WK2] PluginInformation.cpp fails to build because of missing ENABLE(NETSCAPE...
Zoltan Arvai
Reported 2013-05-13 02:27:20 PDT
New file Shared/Plugins/Netscape/PluginInformation.cpp landed in http://trac.webkit.org/changeset/149904 includes WebKit2/UIProcess/Plugins/PluginInfoStore.h and refers to it in line 103 with: map.set(pluginInformationDefaultLoadPolicyKey(), WebUInt64::create(toWKPluginLoadPolicy(PluginInfoStore::policyForPlugin(plugin)))); If NETSCAPE_PLUGIN_API is not enabled, then the build will fail, because ENABLE(NETSCAPE_PLUGIN_API) guarded in PluginInfoStore.h but not in PluginInformation.cpp. It seems that happened on Qt Mountain Lion bot: /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp:103:93: error: use of undeclared identifier 'PluginInfoStore' map.set(pluginInformationDefaultLoadPolicyKey(), WebUInt64::create(toWKPluginLoadPolicy(PluginInfoStore::policyForPlugin(plugin))));
Attachments
Patch (1.72 KB, patch)
2013-05-15 05:43 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2013-05-15 05:43:12 PDT
Created attachment 201821 [details] Patch
Jocelyn Turcotte
Comment 2 2013-05-15 07:32:07 PDT
Comment on attachment 201821 [details] Patch Ideally it feels like the whole file and its header should also be guarded, but WebPageProxy::didFailToInitializePlugin is one use that would difficult to wrap. So I guess it's fine to guard it that way, LGTM.
Andras Becsi
Comment 3 2013-05-16 01:45:50 PDT
Committed r150178: <http://trac.webkit.org/changeset/150178>
Note You need to log in before you can comment on or make changes to this bug.