Bug 116015 – [Win] REGRESSION(r149944): mmap is not available on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zoltan Arvai]

After r149944 Qt Win build is failing:

C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\ArgumentEncoder.cpp(51) : error C3861: 'munmap': identifier not found
C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\ArgumentEncoder.cpp(75) : error C2065: 'PROT_READ' : undeclared identifier
C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\ArgumentEncoder.cpp(75) : error C2065: 'PROT_WRITE' : undeclared identifier
C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\ArgumentEncoder.cpp(75) : error C2065: 'MAP_ANON' : undeclared identifier
C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\ArgumentEncoder.cpp(75) : error C2065: 'MAP_PRIVATE' : undeclared identifier
C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\ArgumentEncoder.cpp(75) : error C3861: 'mmap': identifier not found
C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\ArgumentEncoder.cpp(82) : error C3861: 'munmap': identifier not found

And after r149945:

C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\Platform\CoreIPC\ArgumentEncoder.cpp(32) : fatal error C1083: Cannot open include file: 'sys/mman.h': No such file or directory

Can you check it, please?

[Csaba Osztrogonác]

(In reply to comment #0)
> After r149944 Qt Win build is failing:
> Can you check it, please?

Zoltán, Apple isn't responsible to fix any Qt-WK2 related build 
breakages. So it would be great if you can check and fix it yourself 
instead of asking others to do it. ;-)

[Zoltan Arvai]

I found similar things in WTF/wtf/TCSystemAlloc.cpp where #if guards are used for MMAP and VIRTUALALLOC capable ports.

[Jocelyn Turcotte]

Created attachment 201572 [details]
Patch

[WebKit Commit Bot]

Attachment 201572 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp']" exit_code: 1
Source/WebKit2/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jocelyn Turcotte]

Created attachment 201575 [details]
Patch

Fix the style.

[Anders Carlsson]

Comment on attachment 201575 [details]
Patch

There’s no reason to call VirtualAlloc/VirtualFree on Windows; you can keep calling malloc/free.

[Jocelyn Turcotte]

Created attachment 201586 [details]
Patch

Use fastAlloc instead of VirtualAlloc and use mmap only on OS(DARWIN).

[Jocelyn Turcotte]

Created attachment 201587 [details]
Patch

Reword the ChangeLog.

[WebKit Commit Bot]

Comment on attachment 201587 [details]
Patch

Clearing flags on attachment: 201587

Committed r150079: <http://trac.webkit.org/changeset/150079>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.