Bug 116011 - Remove unused "type" field from DictionaryPopupInfo
Summary: Remove unused "type" field from DictionaryPopupInfo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-12 23:26 PDT by Alexey Proskuryakov
Modified: 2013-05-14 04:37 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (7.62 KB, patch)
2013-05-12 23:31 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-05-12 23:26:51 PDT 
Looks like this field is completely unused. Also, PDFPlugin sets it incorrectly, so we couldn't use this data even if we needed it.
Comment 1 Alexey Proskuryakov 2013-05-12 23:31:59 PDT 
Created attachment 201531 [details]
proposed patch

Let's see what EWS thinks, but I couldn't find any uses in other ports, too.
Comment 2 WebKit Commit Bot 2013-05-14 04:37:13 PDT 
Comment on attachment 201531 [details]
proposed patch

Clearing flags on attachment: 201531

Committed r150064: <http://trac.webkit.org/changeset/150064>
Comment 3 WebKit Commit Bot 2013-05-14 04:37:15 PDT 
All reviewed patches have been landed.  Closing bug.