Bug 116009 – [Mac] Move writeRange/PlainText/URL from ClipboardMac to PasteboardMac

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Darin Adler]

[Mac] Move writeRange/PlainText/URL from ClipboardMac to PasteboardMac

[Darin Adler]

Created attachment 201529 [details]
Patch

[Andreas Kling]

Comment on attachment 201529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201529&action=review

r=me

> Source/WebCore/dom/Clipboard.cpp:321
> +void Clipboard::writeRange(Range* range, Frame* frame)
> +{
> +    ASSERT(range);
> +    ASSERT(frame);

I'm starting to wonder why we bother with things like this instead of passing things by reference where they are always supposed to be non-null.

> Source/WebCore/dom/Clipboard.cpp:322
> +    // FIXME: This is design mistake, a layering violation that should be fixed.

a* design mistake

> Source/WebCore/dom/Clipboard.cpp:336
> +    // FIXME: This is design mistake, a layering violation that should be fixed.

*a design mistake

[Darin Adler]

Comment on attachment 201529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201529&action=review

>> Source/WebCore/dom/Clipboard.cpp:321
>> +    ASSERT(frame);
> 
> I'm starting to wonder why we bother with things like this instead of passing things by reference where they are always supposed to be non-null.

I agree, but it’s a bit of a deep subject since it’s about idiom, not just null-ness.

[Darin Adler]

Committed r150016: <http://trac.webkit.org/changeset/150016>