Bug 116000 - [Mac] Move clearData from ClipboardMac to PasteboardMac
Summary: [Mac] Move clearData from ClipboardMac to PasteboardMac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 115980
  Show dependency treegraph
 
Reported: 2013-05-12 19:29 PDT by Darin Adler
Modified: 2013-05-12 22:04 PDT (History)
2 users (show)

See Also:


Attachments
Patch (9.78 KB, patch)
2013-05-12 19:33 PDT, Darin Adler
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-05-12 19:29:50 PDT
[Mac] Move clearData from ClipboardMac to PasteboardMac
Comment 1 Darin Adler 2013-05-12 19:33:48 PDT
Created attachment 201520 [details]
Patch
Comment 2 Andreas Kling 2013-05-12 19:39:52 PDT
Comment on attachment 201520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201520&action=review

r=me

> Source/WebCore/platform/mac/PasteboardMac.mm:606
> +    if (qType == "url")

else if
(I know you're just moving this.)
Comment 3 Darin Adler 2013-05-12 19:40:56 PDT
Committed r149977: <http://trac.webkit.org/changeset/149977>
Comment 4 Darin Adler 2013-05-12 21:03:17 PDT
(In reply to comment #2)
> > Source/WebCore/platform/mac/PasteboardMac.mm:606
> > +    if (qType == "url")
> 
> else if

I’ll do that in a separate patch.
Comment 5 Darin Adler 2013-05-12 22:04:29 PDT
(In reply to comment #4)
> (In reply to comment #2)
> > > Source/WebCore/platform/mac/PasteboardMac.mm:606
> > > +    if (qType == "url")
> > 
> > else if
> 
> I’ll do that in a separate patch.

Nah, on second thought I prefer not to try to improve the style on this old code right now. It needs a lot of work, and the else is the least of it.