The save sheet comes out where the toolbar is expected to be if the labels are showing (1px off still). In other toolbar modes the sheet floats in the middle of the window. This is based on NSWindow's contentBorderThickness. We should be updating contentBorderThickness anyway to get the right window shadow under the different height toolbars. This just makes it obvious we are not setting this for the different modes. <rdar://problem/13871067>
Created attachment 201513 [details] Patch
Comment on attachment 201513 [details] Patch Looks good to me. Can we get an owner to r+ the WK2 part (very simple).
Comment on attachment 201513 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201513&action=review > Source/WebCore/ChangeLog:10 > + (InspectorFrontendClient): It's best to remove such erroneous prepare-ChangeLog output, as it doesn't help people who are reading ChangeLogs. One day, someone should fix prepare-ChangeLog.
Comment on attachment 201513 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201513&action=review > Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h:89 > + virtual void setToolbarHeight(unsigned); OVERRIDE > Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:96 > + virtual void setToolbarHeight(unsigned); OVERRIDE > Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h:113 > + virtual void setToolbarHeight(unsigned); OVERRIDE > Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h:99 > + virtual void setToolbarHeight(unsigned); OVERRIDE > Source/WebKit/win/WebCoreSupport/WebInspectorClient.h:112 > + virtual void setToolbarHeight(unsigned); OVERRIDE > Source/WebKit2/UIProcess/WebInspectorProxy.h:130 > +#if PLATFORM(MAC) > + void setToolbarHeight(unsigned height) { platformSetToolbarHeight(height); } > +#else > + void setToolbarHeight(unsigned) { } > +#endif > + Instead of this, you should have both setToolbarHeight and platformSetToolbarHeight defined for both platforms and platformSetToolbarHeight() implemented as { notImplemented(); }
I sign off on this with the comments above.
r150041 (and a change to the Safari Inspector)