Bug 115995 – Node: Use FINAL instead of the non-virtual shadowing hack.

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Andreas Kling]

WebCore::Node currently has:

const AtomicString& localName() const { return virtualLocalName(); }
const AtomicString& namespaceURI() const { return virtualNamespaceURI(); }
const AtomicString& prefix() const { return virtualPrefix(); }

These are then shadowed on Element to avoid virtual dispatch when calling through on subclass pointers.
While this is pretty neat, we should just use FINAL instead. Yup.

[Andreas Kling]

Oh, also this:

RenderStyle* computedStyle(PseudoId pseudoElementSpecifier = NOPSEUDO) { return virtualComputedStyle(pseudoElementSpecifier); }

[Andreas Kling]

Created attachment 201511 [details]
Patch

Actually, never mind computedStyle(), we want that to be fast for non-SVG elements and we can't make it FINAL on Element since SVGElement overrides it.
This patch changes prefix/namespaceURI/localName to use FINAL.

[Andreas Kling]

Committed r149974: <http://trac.webkit.org/changeset/149974>

[Darin Adler]

The non-virtual shadowing *design pattern*. Hack, my foot ;-)

[Andreas Kling]

(In reply to comment #4)
> The non-virtual shadowing *design pattern*. Hack, my foot ;-)

<http://i.imgur.com/sXXky9V.jpg>