Bug 115989 - Remove Complex.h from WTF
Summary: Remove Complex.h from WTF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-12 11:01 PDT by Anders Carlsson
Modified: 2013-05-12 14:27 PDT (History)
15 users (show)

See Also:

Attachments
Patch (19.24 KB, patch)
2013-05-12 11:07 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (19.45 KB, patch)
2013-05-12 11:33 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (19.52 KB, patch)
2013-05-12 12:06 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (19.76 KB, patch)
2013-05-12 13:35 PDT, Anders Carlsson 		bdakin: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-05-12 11:01:57 PDT 
Remove Complex.h from WTF
Comment 1 Anders Carlsson 2013-05-12 11:07:39 PDT 
Created attachment 201498 [details]
Patch
Comment 2 EFL EWS Bot 2013-05-12 11:29:58 PDT 
Comment on attachment 201498 [details]
Patch

Attachment 201498 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/427597
Comment 3 EFL EWS Bot 2013-05-12 11:31:47 PDT 
Comment on attachment 201498 [details]
Patch

Attachment 201498 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/464008
Comment 4 Anders Carlsson 2013-05-12 11:33:22 PDT 
Created attachment 201499 [details]
Patch
Comment 5 EFL EWS Bot 2013-05-12 11:43:17 PDT 
Comment on attachment 201499 [details]
Patch

Attachment 201499 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/297513
Comment 6 EFL EWS Bot 2013-05-12 11:47:51 PDT 
Comment on attachment 201499 [details]
Patch

Attachment 201499 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/395538
Comment 7 Chris Dumez 2013-05-12 11:55:10 PDT 
Comment on attachment 201499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201499&action=review

> Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:-38
> -#include <wtf/Complex.h>

Needs to be replaced by #include <complex> to fix EFL build.
Comment 8 Andreas Kling 2013-05-12 12:04:00 PDT 
Comment on attachment 201499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201499&action=review

r=me with EFL build fixed.

> Source/WTF/ChangeLog:9
> +        The header is used by three files in WebCore, so just use std::complex<double> and std::poolar directly.

poolar :|
Comment 9 Anders Carlsson 2013-05-12 12:06:24 PDT 
Created attachment 201502 [details]
Patch
Comment 10 Build Bot 2013-05-12 12:44:13 PDT 
Comment on attachment 201502 [details]
Patch

Attachment 201502 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/427608
Comment 11 Anders Carlsson 2013-05-12 13:35:59 PDT 
Created attachment 201508 [details]
Patch
Comment 12 Anders Carlsson 2013-05-12 14:27:12 PDT 
Committed r149970: <http://trac.webkit.org/changeset/149970>