[Mac] Give every Clipboard an underlying Pasteboard
Created attachment 201481 [details] Patch
Comment on attachment 201481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201481&action=review r=me, glad to see this is moving :) > Source/WebCore/dom/Clipboard.h:37 > +#define USE_LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS !PLATFORM(MAC) I would have named this WTF_USE_LEGACY_... and used #if USE(LEGACY_...) > Source/WebCore/platform/mac/ClipboardMac.mm:60 > - : Clipboard(policy, clipboardType) > + : Clipboard(policy, clipboardType, Pasteboard::create(m_pasteboardName)) > , m_pasteboardName(pasteboardName) Is m_pasteboardName guaranteed to be initialized before you pass it to the base class ctor here?
(In reply to comment #2) > > Source/WebCore/dom/Clipboard.h:37 > > +#define USE_LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS !PLATFORM(MAC) > > I would have named this WTF_USE_LEGACY_... and used #if USE(LEGACY_...) OK. I can change that. > > Source/WebCore/platform/mac/ClipboardMac.mm:60 > > - : Clipboard(policy, clipboardType) > > + : Clipboard(policy, clipboardType, Pasteboard::create(m_pasteboardName)) > > , m_pasteboardName(pasteboardName) > > Is m_pasteboardName guaranteed to be initialized before you pass it to the base class ctor here? It’s not. I thought I had fixed that! I’ll land with it fixed.
Committed r149972: <http://trac.webkit.org/changeset/149972>