Bug 115967 – [GTK] Add a basic cmake build for WTF and JavaScriptCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

This is the first step to a full cmake build.

[Martin Robinson]

Created attachment 201469 [details]
Patch

[EFL EWS Bot]

Comment on attachment 201469 [details]
Patch

Attachment 201469 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/460188

[EFL EWS Bot]

Comment on attachment 201469 [details]
Patch

Attachment 201469 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/451272

[Martin Robinson]

Created attachment 201475 [details]
Try to fix the EFL build

[Laszlo Gombos]

Comment on attachment 201475 [details]
Try to fix the EFL build

View in context: https://bugs.webkit.org/attachment.cgi?id=201475&action=review

Looks good to me, assuming commnets are fixed in Source/cmake/Find*.cmake

> Source/JavaScriptCore/PlatformGTK.cmake:2
> +    jit/ExecutableAllocatorFixedVMPool.cpp

We should try to move this out from the GTK specific cmake file into the shared cmake file in a separate/follow-up patch if possible. It seem jit/ExecutableAllocatorFixedVMPool.cpp has a guard already.

> Source/WTF/wtf/PlatformGTK.cmake:3
> +    OSAllocatorPosix.cpp
> +    OSAllocatorWin.cpp

Ditto for these 2 files and possible others in this list.

> Source/cmake/FindGAIL3.cmake:6
> +#  GAIL3_FOUND - system has Cairo
> +#  GAIL3_INCLUDE_DIRS - the Cairo include directories
> +#  GAIL3_LIBRARIES - link these to use Cairo

Cairo --> Gail3.

> Source/cmake/FindGDK3.cmake:6
> +#  GDK3_FOUND - system has Cairo
> +#  GDK3_INCLUDE_DIRS - the Cairo include directories
> +#  GDK3_LIBRARIES - link these to use Cairo

Cairo -> GDK3

> Source/cmake/FindGTK3.cmake:6
> +#  GTK3_FOUND - system has Cairo
> +#  GTK3_INCLUDE_DIRS - the Cairo include directories
> +#  GTK3_LIBRARIES - link these to use Cairo

Cairo -> GTK3.

> Source/cmake/FindXt.cmake:6
> +#  XT_FOUND - system has Cairo
> +#  XT_INCLUDE_DIRS - the Cairo include directories
> +#  XT_LIBRARIES - link these to use Cairo

Cairo -> Xt.

[Martin Robinson]

Committed r149968: <http://trac.webkit.org/changeset/149968>

[Martin Robinson]

(In reply to comment #5)
> (From update of attachment 201475 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201475&action=review
> 
> Looks good to me, assuming commnets are fixed in Source/cmake/Find*.cmake

Thanks for the review.

> 
> > Source/JavaScriptCore/PlatformGTK.cmake:2
> > +    jit/ExecutableAllocatorFixedVMPool.cpp
> 
> We should try to move this out from the GTK specific cmake file into the shared cmake file in a separate/follow-up patch if possible. It seem jit/ExecutableAllocatorFixedVMPool.cpp has a guard already.

Doing that at bug 115992.