RESOLVED FIXED 115965
[GTK] Move defines that will never be configured to Platform.h 
https://bugs.webkit.org/show_bug.cgi?id=115965
Summary [GTK] Move defines that will never be configured to Platform.h
Martin Robinson
Reported 2013-05-11 11:47:07 PDT
Instead of putting defines that are never configured (think USE_HARFBUZZ) into the autoconf configuration file, we should just put them in Platform.h. This has a couple benefits. It makes it easier for developers from other ports to see what GTK+ uses and it also lets us share the defines with the cmake build.
Attachments
Patch (2.67 KB, patch)
2013-05-11 11:53 PDT, Martin Robinson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2013-05-11 11:53:50 PDT
Created attachment 201467 [details] Patch
Laszlo Gombos
Comment 2 2013-05-12 09:36:52 PDT
Great !
Martin Robinson
Comment 3 2013-05-12 11:10:05 PDT
Committed r149966: <http://trac.webkit.org/changeset/149966>
Note You need to log in before you can comment on or make changes to this bug.