Bug 115965 - [GTK] Move defines that will never be configured to Platform.h
Summary: [GTK] Move defines that will never be configured to Platform.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 115966
  Show dependency tree / graph
 
Reported: 2013-05-11 11:47 PDT by Martin Robinson
Modified: 2013-05-12 11:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.67 KB, patch)
2013-05-11 11:53 PDT, Martin Robinson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-05-11 11:47:07 PDT 
Instead of putting defines that are never configured (think USE_HARFBUZZ) into the autoconf configuration file, we should just put them in Platform.h. This has a couple benefits. It makes it easier for developers from other ports to see what GTK+ uses and it also lets us share the defines with the cmake build.
Comment 1 Martin Robinson 2013-05-11 11:53:50 PDT 
Created attachment 201467 [details]
Patch
Comment 2 Laszlo Gombos 2013-05-12 09:36:52 PDT 
Great !
Comment 3 Martin Robinson 2013-05-12 11:10:05 PDT 
Committed r149966: <http://trac.webkit.org/changeset/149966>