Bug 115955 – Implement .onended event listener for AudioBufferSourceNode and OscillatorNode

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Web Audio

[Praveen Jadhav]

AudioBufferSourceNode and OscillatorNode should sent .onended event as per the latest webaudio specifications.

[Praveen Jadhav]

Created attachment 201454 [details]
Patch

Patch for onended event implementation in AudioBufferSourceNode and OscillatorNode.

[WebKit Commit Bot]

Attachment 201454 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/webaudio/audiobuffersource-stop-expected.txt', u'LayoutTests/webaudio/audiobuffersource-stop.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp', u'Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h', u'Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl', u'Source/WebCore/Modules/webaudio/OscillatorNode.cpp', u'Source/WebCore/Modules/webaudio/OscillatorNode.h', u'Source/WebCore/Modules/webaudio/OscillatorNode.idl', u'Source/WebCore/dom/EventTarget.h', u'Source/WebCore/dom/EventTargetFactory.in']" exit_code: 1
Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp:357:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/Modules/webaudio/OscillatorNode.cpp:354:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Rogers]

Comment on attachment 201454 [details]
Patch

Thanks Praveen, but we're working on a separate patch to simply make AudioNode an EventTarget.  Then we need to create special optimized code to not fire an event if there are no event listeners to avoid calling callOnMainThread()

[Praveen Jadhav]

(In reply to comment #3)
> (From update of attachment 201454 [details])
> Thanks Praveen, but we're working on a separate patch to simply make AudioNode an EventTarget.  Then we need to create special optimized code to not fire an event if there are no event listeners to avoid calling callOnMainThread()

That would be really nice not to call callOnMainThread() unnecessarily if event listener isn't present. As of now, ScriptProcessorNode too has this issue and can be avoided with your approach. Will wait for your patch.. :-)

[Praveen Jadhav]

*** This bug has been marked as a duplicate of bug 116798 ***