Bug 115943 - SpeculativeJIT::checkArray should use the correct ExitKind
Summary: SpeculativeJIT::checkArray should use the correct ExitKind
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-10 16:19 PDT by Mark Hahnenberg
Modified: 2013-05-11 16:25 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.57 KB, patch)
2013-05-10 16:25 PDT, Mark Hahnenberg
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-05-10 16:19:55 PDT
Currently it uses Uncountable, which gives us no information if we end up exiting due to a mismatched ClassInfo pointer. It should instead use BadType and should pass the correct JSValueSource and Node instead of passing empty values.
Comment 1 Mark Hahnenberg 2013-05-10 16:25:31 PDT
Created attachment 201438 [details]
Patch
Comment 2 Filip Pizlo 2013-05-10 16:26:06 PDT
Comment on attachment 201438 [details]
Patch

r=me
Comment 3 Filip Pizlo 2013-05-10 16:26:38 PDT
Branch, please.
Comment 4 Mark Hahnenberg 2013-05-11 16:25:55 PDT
Committed r149943: <http://trac.webkit.org/changeset/149943>