RESOLVED FIXED 115938
Rename StructureCheckHoistingPhase to TypeCheckHoistingPhase 
https://bugs.webkit.org/show_bug.cgi?id=115938
Summary Rename StructureCheckHoistingPhase to TypeCheckHoistingPhase
Mark Hahnenberg
Reported 2013-05-10 14:51:53 PDT
We're going to add some more types of check hoisting soon, so let's have the right name here.
Attachments
Patch (50.99 KB, patch)
2013-05-10 14:58 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2013-05-10 14:58:03 PDT
Created attachment 201428 [details] Patch
WebKit Commit Bot
Comment 2 2013-05-10 14:59:12 PDT
Attachment 201428 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/dfg/DFGDriver.cpp', u'Source/JavaScriptCore/dfg/DFGStructureCheckHoistingPhase.cpp', u'Source/JavaScriptCore/dfg/DFGStructureCheckHoistingPhase.h', u'Source/JavaScriptCore/dfg/DFGTypeCheckHoistingPhase.cpp', u'Source/JavaScriptCore/dfg/DFGTypeCheckHoistingPhase.h']" exit_code: 1 Source/JavaScriptCore/dfg/DFGTypeCheckHoistingPhase.cpp:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Hahnenberg
Comment 3 2013-05-10 16:14:31 PDT
Committed r149911: <http://trac.webkit.org/changeset/149911>
Mark Hahnenberg
Comment 4 2013-05-11 17:26:16 PDT
Landed on the branch as well.
Note You need to log in before you can comment on or make changes to this bug.