Bug 115914 - [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
Summary: [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-10 09:31 PDT by Carlos Garcia Campos
Modified: 2013-05-12 02:05 PDT (History)
6 users (show)

See Also:


Attachments
Patch (49.85 KB, patch)
2013-05-10 10:35 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-05-10 09:31:33 PDT
We already bumped to gtk+ 3.6, so we can get rid of most of the #ifdefed code.
Comment 1 Carlos Garcia Campos 2013-05-10 10:35:45 PDT
Created attachment 201360 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-10 10:37:10 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2013-05-10 11:25:27 PDT
Comment on attachment 201360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201360&action=review

> Source/WebCore/platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:201
> -    GdkCursor* cursor = blankCursor();
> -    gdk_window_set_cursor(window, cursor);
> +    GRefPtr<GdkCursor> cursor = adoptGRef(gdk_cursor_new(GDK_BLANK_CURSOR));
> +    gdk_window_set_cursor(window, cursor.get());

Nice!
Comment 4 Carlos Garcia Campos 2013-05-12 02:05:28 PDT
Committed r149952: <http://trac.webkit.org/changeset/149952>