Bug 115904 – [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

We already bumped to glib 2.3.6, so we can get rid of most of the #ifdefed code.

[Carlos Garcia Campos]

Created attachment 201339 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

Comment on attachment 201339 [details]
Patch

Nice cleanup.

[Carlos Garcia Campos]

Committed r149879: <http://trac.webkit.org/changeset/149879>

[Zoltan Arvai]

After the patch Qt Linux MIPS32R2 LE Release bot failed to build: 

/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/gobject/GRefPtr.cpp: In function 'T* WTF::refGPtr(T*) [with T = GBytes]':
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/gobject/GRefPtr.cpp:69: error: 'g_bytes_ref' was not declared in this scope
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/gobject/GRefPtr.cpp: In function 'void WTF::derefGPtr(T*) [with T = GBytes]':
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/gobject/GRefPtr.cpp:76: error: 'g_bytes_unref' was not declared in this scope

http://build.webkit.org/builders/Qt%20Linux%20MIPS32R2%20LE%20Release/builds/14574/steps/compile-webkit/logs/stdio

[Carlos Garcia Campos]

(In reply to comment #5)
> After the patch Qt Linux MIPS32R2 LE Release bot failed to build: 
> 
> /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/gobject/GRefPtr.cpp: In function 'T* WTF::refGPtr(T*) [with T = GBytes]':
> /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/gobject/GRefPtr.cpp:69: error: 'g_bytes_ref' was not declared in this scope
> /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/gobject/GRefPtr.cpp: In function 'void WTF::derefGPtr(T*) [with T = GBytes]':
> /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/gobject/GRefPtr.cpp:76: error: 'g_bytes_unref' was not declared in this scope
> 
> http://build.webkit.org/builders/Qt%20Linux%20MIPS32R2%20LE%20Release/builds/14574/steps/compile-webkit/logs/stdio

Oops, sorry. What glib version is required by qtwebkit? Doesn't qt use gst 1.0 already? gst 1 requires glib 2.32 that's why I assumed this would not break qt build (and that EWS passed).

[Balazs Kilvady]

> Oops, sorry. What glib version is required by qtwebkit? Doesn't qt use gst 1.0 already? gst 1 requires glib 2.32 that's why I assumed this would not break qt build (and that EWS passed).

Qt Linux MIPS32R2 LE Release bot uses gst 0.10 and glib 2.24.2.

[Carlos Garcia Campos]

(In reply to comment #7)
> > Oops, sorry. What glib version is required by qtwebkit? Doesn't qt use gst 1.0 already? gst 1 requires glib 2.32 that's why I assumed this would not break qt build (and that EWS passed).
> 
> Qt Linux MIPS32R2 LE Release bot uses gst 0.10 and glib 2.24.2.

Ok, thanks, I'll fix it then.

[Carlos Garcia Campos]

(In reply to comment #8)
> (In reply to comment #7)
> > > Oops, sorry. What glib version is required by qtwebkit? Doesn't qt use gst 1.0 already? gst 1 requires glib 2.32 that's why I assumed this would not break qt build (and that EWS passed).
> > 
> > Qt Linux MIPS32R2 LE Release bot uses gst 0.10 and glib 2.24.2.
> 
> Ok, thanks, I'll fix it then.

Should be fixed now:

http://trac.webkit.org/changeset/150019

[Zoltan Arvai]

(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > > Oops, sorry. What glib version is required by qtwebkit? Doesn't qt use gst 1.0 already? gst 1 requires glib 2.32 that's why I assumed this would not break qt build (and that EWS passed).
> > > 
> > > Qt Linux MIPS32R2 LE Release bot uses gst 0.10 and glib 2.24.2.
> > 
> > Ok, thanks, I'll fix it then.
> 
> Should be fixed now:
> 
> http://trac.webkit.org/changeset/150019

The Qt MIPS bot is green again. Thank you.