RESOLVED FIXED 115900
Remove ScriptInstance.h 
https://bugs.webkit.org/show_bug.cgi?id=115900
Summary Remove ScriptInstance.h
Anders Carlsson
Reported 2013-05-10 05:36:22 PDT
Remove ScriptInstance.h
Attachments
Patch (15.13 KB, patch)
2013-05-10 05:40 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-05-10 05:40:15 PDT
Created attachment 201338 [details] Patch
WebKit Commit Bot
Comment 2 2013-05-10 05:41:18 PDT
Attachment 201338 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/ScriptController.h', u'Source/WebCore/bindings/js/ScriptControllerMac.mm', u'Source/WebCore/bindings/js/ScriptInstance.h', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.h', u'Source/WebCore/platform/graphics/wince/MediaPlayerProxy.h', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp']" exit_code: 1 Source/WebCore/platform/graphics/wince/MediaPlayerProxy.h:56: The return type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2013-05-10 05:44:03 PDT
Comment on attachment 201338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201338&action=review r=me >> Source/WebCore/platform/graphics/wince/MediaPlayerProxy.h:56 >> - ScriptInstance pluginInstance(); >> + RefPtr<JSC::Bindings::Instance> pluginInstance(); > > The return type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] wat
Anders Carlsson
Comment 4 2013-05-10 05:51:30 PDT
Committed r149871: <http://trac.webkit.org/changeset/149871>
Note You need to log in before you can comment on or make changes to this bug.