Bug 115898 – Begin making SecurityOrigin immutable

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Anders Carlsson]

Begin making SecurityOrigin immutable

[Anders Carlsson]

Created attachment 201334 [details]
Patch

[Andreas Kling]

Comment on attachment 201334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201334&action=review

r=me with some fixing!

> Source/WebCore/page/SecurityOrigin.cpp:219
> +    return adoptRef(new SecurityOrigin(m_protocol, m_host, domain, m_filePath, m_port, m_isUnique, m_universalAccess, m_domainWasSetInDOM, m_canLoadLocalResources, m_storageBlockingPolicy, m_enforceFilePathSeparation, m_needsDatabaseIdentifierQuirkForFiles));

You're just passing m_domainWasSetInDOM again here, that argument should be true.

> Source/WebCore/page/SecurityOrigin.h:80
> -    void setDomainFromDOM(const String& newDomain);
> +    PassRefPtr<SecurityOrigin> securityOriginWithDomainSetFromDOM(const String& newDomain) const;

I'd call this securityOriginWithDomainSetFromDOM().

> Source/WebCore/page/SecurityOrigin.h:140
> -    void grantUniversalAccess();
> +    PassRefPtr<SecurityOrigin> securityOriginWithUniversalAccessGranted() const;

I'd call this copyWithUniversalAccessGranted().

[Andreas Kling]

(In reply to comment #2)
> (From update of attachment 201334 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201334&action=review
> 
> > Source/WebCore/page/SecurityOrigin.h:80
> > -    void setDomainFromDOM(const String& newDomain);
> > +    PassRefPtr<SecurityOrigin> securityOriginWithDomainSetFromDOM(const String& newDomain) const;
> 
> I'd call this securityOriginWithDomainSetFromDOM().

I'd call this copyWithDomainSetFromDOM().

[Andreas Kling]

(In reply to comment #2)
> (From update of attachment 201334 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201334&action=review
> 
> > Source/WebCore/page/SecurityOrigin.h:80
> > -    void setDomainFromDOM(const String& newDomain);
> > +    PassRefPtr<SecurityOrigin> securityOriginWithDomainSetFromDOM(const String& newDomain) const;
> 
> I'd call this securityOriginWithDomainSetFromDOM().

I'd call this copyWithDomainSetFromDOM().

[Anders Carlsson]

Committed r149866: <http://trac.webkit.org/changeset/149866>

[Anders Carlsson]

Reverted r149866 for reason:

Broke

Committed r149869: <http://trac.webkit.org/changeset/149869>

[Anders Carlsson]

This won’t work since we rely on subframes having their origins linked to their parent frames.