Bug 115877 - Remove extra spaces between right angle brackets in template declarations
Summary: Remove extra spaces between right angle brackets in template declarations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-09 15:18 PDT by Anders Carlsson
Modified: 2013-05-09 15:37 PDT (History)
6 users (show)

See Also:


Attachments
Patch (161.85 KB, patch)
2013-05-09 15:26 PDT, Anders Carlsson
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-05-09 15:18:04 PDT
Remove extra spaces between right angle brackets in template declarations
Comment 1 Anders Carlsson 2013-05-09 15:26:28 PDT
Created attachment 201289 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-09 15:28:49 PDT
Attachment 201289 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp', u'Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h', u'Source/WebKit2/NetworkProcess/NetworkProcess.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/SchedulableLoader.cpp', u'Source/WebKit2/NetworkProcess/SchedulableLoader.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h', u'Source/WebKit2/Platform/CoreIPC/Connection.cpp', u'Source/WebKit2/Platform/CoreIPC/Connection.h', u'Source/WebKit2/Platform/WorkQueue.h', u'Source/WebKit2/PluginProcess/PluginProcess.h', u'Source/WebKit2/Scripts/webkit2/messages_unittest.py', u'Source/WebKit2/Shared/BlockingResponseMap.h', u'Source/WebKit2/Shared/ChildProcessProxy.h', u'Source/WebKit2/Shared/ImmutableArray.cpp', u'Source/WebKit2/Shared/ImmutableArray.h', u'Source/WebKit2/Shared/ImmutableDictionary.cpp', u'Source/WebKit2/Shared/ImmutableDictionary.h', u'Source/WebKit2/Shared/Network/CustomProtocols/CustomProtocolManager.h', u'Source/WebKit2/Shared/SecurityOriginData.cpp', u'Source/WebKit2/Shared/SessionState.cpp', u'Source/WebKit2/Shared/StatisticsData.h', u'Source/WebKit2/Shared/UserMessageCoders.h', u'Source/WebKit2/Shared/WebArchive.cpp', u'Source/WebKit2/Shared/WebContextMenuItem.cpp', u'Source/WebKit2/Shared/WebOpenPanelParameters.cpp', u'Source/WebKit2/Shared/mac/ArgumentCodersMac.mm', u'Source/WebKit2/SharedWorkerProcess/SharedWorkerProcess.h', u'Source/WebKit2/UIProcess/API/mac/WKPrintingView.h', u'Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm', u'Source/WebKit2/UIProcess/API/mac/WKView.mm', u'Source/WebKit2/UIProcess/Downloads/DownloadProxyMap.cpp', u'Source/WebKit2/UIProcess/Downloads/DownloadProxyMap.h', u'Source/WebKit2/UIProcess/GeolocationPermissionRequestManagerProxy.h', u'Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h', u'Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h', u'Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h', u'Source/WebKit2/UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h', u'Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.h', u'Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h', u'Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h', u'Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.cpp', u'Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.h', u'Source/WebKit2/UIProcess/SharedWorkers/SharedWorkerProcessManager.h', u'Source/WebKit2/UIProcess/SharedWorkers/SharedWorkerProcessProxy.h', u'Source/WebKit2/UIProcess/StatisticsRequest.cpp', u'Source/WebKit2/UIProcess/Storage/StorageManager.cpp', u'Source/WebKit2/UIProcess/Storage/StorageManager.h', u'Source/WebKit2/UIProcess/WebApplicationCacheManagerProxy.h', u'Source/WebKit2/UIProcess/WebBackForwardList.cpp', u'Source/WebKit2/UIProcess/WebBackForwardList.h', u'Source/WebKit2/UIProcess/WebContext.cpp', u'Source/WebKit2/UIProcess/WebContext.h', u'Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp', u'Source/WebKit2/UIProcess/WebCookieManagerProxy.h', u'Source/WebKit2/UIProcess/WebDatabaseManagerProxy.cpp', u'Source/WebKit2/UIProcess/WebDatabaseManagerProxy.h', u'Source/WebKit2/UIProcess/WebFormClient.cpp', u'Source/WebKit2/UIProcess/WebFormClient.h', u'Source/WebKit2/UIProcess/WebKeyValueStorageManagerProxy.h', u'Source/WebKit2/UIProcess/WebLoaderClient.cpp', u'Source/WebKit2/UIProcess/WebLoaderClient.h', u'Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.cpp', u'Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.h', u'Source/WebKit2/UIProcess/WebPageContextMenuClient.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/UIProcess/WebProcessProxy.cpp', u'Source/WebKit2/UIProcess/WebProcessProxy.h', u'Source/WebKit2/UIProcess/WebResourceCacheManagerProxy.h', u'Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm', u'Source/WebKit2/WebProcess/ApplicationCache/WebApplicationCacheManager.cpp', u'Source/WebKit2/WebProcess/Geolocation/WebGeolocationManager.cpp', u'Source/WebKit2/WebProcess/IconDatabase/WebIconDatabaseProxy.h', u'Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp', u'Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp', u'Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.h', u'Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.h', u'Source/WebKit2/WebProcess/Notifications/WebNotificationManager.h', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h', u'Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h', u'Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.h', u'Source/WebKit2/WebProcess/Plugins/PDF/SimplePDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginProcessConnectionManager.h', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.h', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp', u'Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.h', u'Source/WebKit2/WebProcess/Storage/WebKeyValueStorageManager.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebDatabaseManager.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/EventDispatcher.h', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/FindController.h', u'Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h', u'Source/WebKit2/WebProcess/WebProcess.cpp', u'Source/WebKit2/WebProcess/WebProcess.h']" exit_code: 1
Source/WebKit2/UIProcess/Downloads/DownloadProxyMap.cpp:70:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:139:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/Shared/ImmutableArray.cpp:49:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:50:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:754:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/WebContext.cpp:556:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h:71:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h:98:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/WebLoaderClient.cpp:248:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:217:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:314:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:325:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:386:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:388:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:392:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:410:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:412:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:417:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:435:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:437:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:528:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:543:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:551:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:554:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/Shared/ImmutableArray.h:54:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/Shared/ImmutableArray.h:73:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/Platform/WorkQueue.h:168:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/WebFormClient.cpp:36:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h:50:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/WebProcessProxy.cpp:501:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/Platform/CoreIPC/Connection.cpp:389:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/Platform/CoreIPC/Connection.cpp:419:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/Platform/CoreIPC/Connection.cpp:653:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:422:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:423:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:501:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:502:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:513:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:514:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:546:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:547:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:564:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:698:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:713:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:802:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:803:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:904:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:1117:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:1118:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp:88:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/WebPageProxy.cpp:871:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/WebPageProxy.cpp:2584:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/WebPageProxy.h:303:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/WebPageProxy.h:838:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/WebFormClient.h:44:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:56:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:57:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:63:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:64:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp:236:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/WebLoaderClient.h:88:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:76:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:99:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:100:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:103:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:104:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:95:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:110:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:214:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:215:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:216:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:62:  Missing spaces around >>  [whitespace/operators] [3]
Total errors found: 72 in 121 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Beth Dakin 2013-05-09 15:31:18 PDT
Comment on attachment 201289 [details]
Patch

It would be awesome if we could teach StyleBot that there are okay in WK2 now.
Comment 4 Anders Carlsson 2013-05-09 15:37:10 PDT
Committed r149848: <http://trac.webkit.org/changeset/149848>