RESOLVED WONTFIX 115875
add atomicAdd and atomicSubtract 
https://bugs.webkit.org/show_bug.cgi?id=115875
Summary add atomicAdd and atomicSubtract
Alex Christensen
Reported 2013-05-09 14:35:12 PDT
Source/WTF/wtf/Atomics.h currently has atomicIncrement and atomicDecrement for adding and subtracting 1 atomically, but there is no way to add and subtract other values atomically using WTF. This is needed in cases like Source/WTF/wtf/text/StringImpl.h line 584, which increments a value by 2. I added atomicAdd and atomicSubtract and tested it on Mac, but I'd prefer someone try this on Windows before reviewing in case I forgot something Windows-specific.
Attachments
Patch (5.27 KB, patch)
2013-05-09 14:38 PDT, Alex Christensen 		benjamin: review-
benjamin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-05-09 14:38:35 PDT
Created attachment 201278 [details] Patch
Benjamin Poulain
Comment 2 2013-05-09 14:44:52 PDT
Comment on attachment 201278 [details] Patch (In reply to comment #0) > Source/WTF/wtf/Atomics.h currently has atomicIncrement and atomicDecrement for adding and subtracting 1 atomically, but there is no way to add and subtract other values atomically using WTF. This is needed in cases like Source/WTF/wtf/text/StringImpl.h line 584, which increments a value by 2. > > I added atomicAdd and atomicSubtract and tested it on Mac, but I'd prefer someone try this on Windows before reviewing in case I forgot something Windows-specific. StringImpl does not use atomic ref-deref. What is this for?
Note You need to log in before you can comment on or make changes to this bug.