UNCONFIRMED 115874
Tools/Scripts/webkit-patch fails with non-ascii characters in file path 
https://bugs.webkit.org/show_bug.cgi?id=115874
Summary Tools/Scripts/webkit-patch fails with non-ascii characters in file path
Kevin Doughty
Reported 2013-05-09 14:34:18 PDT
$ Tools/Scripts/webkit-patch upload Auto-installing package: mechanize Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 84, in <module> main() File "Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/虫/Documents/xcode/svn/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/虫/Documents/xcode/svn/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/虫/Documents/xcode/svn/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 49, in execute state = self._prepare_state(options, args, tool) File "/Volumes/虫/Documents/xcode/svn/WebKit/Tools/Scripts/webkitpy/tool/commands/upload.py", line 296, in _prepare_state state["bug_id"] = self._bug_id(options, args, tool, state) File "/Volumes/虫/Documents/xcode/svn/WebKit/Tools/Scripts/webkitpy/tool/commands/upload.py", line 199, in _bug_id bug_id = tool.checkout().bug_id_for_this_commit(options.git_commit, changed_files) File "/Volumes/虫/Documents/xcode/svn/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 144, in bug_id_for_this_commit return parse_bug_id_from_changelog(self.commit_message_for_this_commit(git_commit, changed_files).message()) File "/Volumes/虫/Documents/xcode/svn/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 123, in commit_message_for_this_commit changelog_paths = self.modified_changelogs(git_commit, changed_files) File "/Volumes/虫/Documents/xcode/svn/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 117, in modified_changelogs return self._modified_files_matching_predicate(git_commit, self.is_path_to_changelog, changed_files=changed_files) File "/Volumes/虫/Documents/xcode/svn/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 114, in _modified_files_matching_predicate return filter(predicate, map(self._scm.absolute_path, changed_files)) File "/Volumes/虫/Documents/xcode/svn/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 83, in absolute_path return self._filesystem.join(self.checkout_root, repository_relative_path) File "/Volumes/虫/Documents/xcode/svn/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 129, in join return os.path.join(*comps) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py", line 71, in join path += '/' + b UnicodeDecodeError: 'ascii' codec can't decode byte 0xe8 in position 9: ordinal not in range(128) ("虫" from /Volumes/虫/ actually means insect, not a software bug.)
Attachments
Add attachment proposed patch, testcase, etc.
Note You need to log in before you can comment on or make changes to this bug.