RESOLVED FIXED 115862
[Mac] CFError leak under Objective-C garbage collection 
https://bugs.webkit.org/show_bug.cgi?id=115862
Summary [Mac] CFError leak under Objective-C garbage collection
Darin Adler
Reported 2013-05-09 09:08:34 PDT
[Mac] ResourceError leak under Objective-C garbage collection
Attachments
Patch (1.82 KB, patch)
2013-05-09 09:11 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-05-09 09:11:20 PDT
Created attachment 201244 [details] Patch
WebKit Commit Bot
Comment 2 2013-05-09 11:42:08 PDT
Comment on attachment 201244 [details] Patch Clearing flags on attachment: 201244 Committed r149828: <http://trac.webkit.org/changeset/149828>
WebKit Commit Bot
Comment 3 2013-05-09 11:42:09 PDT
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 4 2013-05-09 14:00:08 PDT
USE(CFNETWORK) is only defined for PLATFORM(IOS) and PLATFORM(WIN), neither of which ever supported Objective-C garbage collection. I'm certain ResourceErrorMac.mm isn't compiled on the Apple Windows port, either. So while this code is semantically more correct, it also doesn't actually fix an actual leak as far as I can tell. Am I missing something?
Darin Adler
Comment 5 2013-05-09 18:17:01 PDT
(In reply to comment #4) > So while this code is semantically more correct, it also doesn't actually fix an actual leak as far as I can tell. That’s right. It fixes a leak we’d have if we turned USE(CFNETWORK) on for Mac.
Darin Adler
Comment 6 2013-05-09 18:18:27 PDT
To give you some context: Anders spotted some other leaks due to code like this, and I believe he fixed those others yesterday.
Note You need to log in before you can comment on or make changes to this bug.