Bug 115862 - [Mac] CFError leak under Objective-C garbage collection
Summary: [Mac] CFError leak under Objective-C garbage collection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-09 09:08 PDT by Darin Adler
Modified: 2013-05-09 18:18 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.82 KB, patch)
2013-05-09 09:11 PDT, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-05-09 09:08:34 PDT
[Mac] ResourceError leak under Objective-C garbage collection
Comment 1 Darin Adler 2013-05-09 09:11:20 PDT
Created attachment 201244 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-09 11:42:08 PDT
Comment on attachment 201244 [details]
Patch

Clearing flags on attachment: 201244

Committed r149828: <http://trac.webkit.org/changeset/149828>
Comment 3 WebKit Commit Bot 2013-05-09 11:42:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 David Kilzer (:ddkilzer) 2013-05-09 14:00:08 PDT
USE(CFNETWORK) is only defined for PLATFORM(IOS) and PLATFORM(WIN), neither of which ever supported Objective-C garbage collection.  I'm certain ResourceErrorMac.mm isn't compiled on the Apple Windows port, either.

So while this code is semantically more correct, it also doesn't actually fix an actual leak as far as I can tell.  Am I missing something?
Comment 5 Darin Adler 2013-05-09 18:17:01 PDT
(In reply to comment #4)
> So while this code is semantically more correct, it also doesn't actually fix an actual leak as far as I can tell.

That’s right. It fixes a leak we’d have if we turned USE(CFNETWORK) on for Mac.
Comment 6 Darin Adler 2013-05-09 18:18:27 PDT
To give you some context: Anders spotted some other leaks due to code like this, and I believe he fixed those others yesterday.