[Mac] ResourceError leak under Objective-C garbage collection
Created attachment 201244 [details]
Comment on attachment 201244 [details]
Clearing flags on attachment: 201244
Committed r149828: <http://trac.webkit.org/changeset/149828>
All reviewed patches have been landed. Closing bug.
USE(CFNETWORK) is only defined for PLATFORM(IOS) and PLATFORM(WIN), neither of which ever supported Objective-C garbage collection. I'm certain ResourceErrorMac.mm isn't compiled on the Apple Windows port, either.
So while this code is semantically more correct, it also doesn't actually fix an actual leak as far as I can tell. Am I missing something?
(In reply to comment #4)
> So while this code is semantically more correct, it also doesn't actually fix an actual leak as far as I can tell.
That’s right. It fixes a leak we’d have if we turned USE(CFNETWORK) on for Mac.
To give you some context: Anders spotted some other leaks due to code like this, and I believe he fixed those others yesterday.