Bug 115852 – [NoInterfaceObject] extended attribute should be removed for several interfaces

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

The following interfaces have the [NoInterfaceObject] extended attribute:
SecurityPolicy, History, Location, Navigator, Performance, PerformanceEntry, PerformanceMark, PerformanceMeasure, PerformanceNavigation, PerformanceResourceTiming, PerformanceTiming and Screen.

This means that there is no corresponding property on the global Window object with the same name.

However, this is incorrect according to their respective specifications:
- http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-history-interface
- http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-location-interface
- https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#securitypolicy
- http://www.w3.org/html/wg/drafts/html/master/webappapis.html#the-navigator-object
- http://www.w3.org/TR/navigation-timing/#performance
- https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html#sec-PerformanceEntry-interface
- http://www.w3.org/TR/navigation-timing/#performancenavigation
- http://www.w3.org/TR/navigation-timing/#performancetiming
- http://www.w3.org/TR/user-timing/#performancemark
- http://www.w3.org/TR/user-timing/#performancemeasure
- http://www.w3c-test.org/webperf/specs/ResourceTiming/#performanceresourcetiming
- http://dev.w3.org/csswg/cssom-view/#the-screen-interface

We should remove [NoInterfaceObject] from these interfaces to match the specs.

I confirmed the following behavior for Firefox:
All of them are exposed except SecurityPolicy, PerformanceEntry, PerformanceMark, PerformanceMeasure, PerformanceResourceTiming. The ones that are not exposed are unimplemented.

Corresponding Blink patch:
https://codereview.chromium.org/14672011/

[Chris Dumez]

Created attachment 201188 [details]
Patch

[Build Bot]

Comment on attachment 201188 [details]
Patch

Attachment 201188 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/342100

New failing tests:
fast/js/global-constructors-attributes.html

[Build Bot]

Created attachment 201238 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[Chris Dumez]

Created attachment 201239 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 201239 [details]
Patch

Clearing flags on attachment: 201239

Committed r149845: <http://trac.webkit.org/changeset/149845>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.