Bug 115850 - Web Inspector: Remove Memory Distribution and Memory Snapshots Panels
Summary: Web Inspector: Remove Memory Distribution and Memory Snapshots Panels
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 114998
  Show dependency tree / graph
 
Reported: 2013-05-09 01:08 PDT by Seokju Kwon
Modified: 2013-05-12 20:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (37.06 KB, patch)
2013-05-09 01:28 PDT, Seokju Kwon 		no flags Details | Formatted Diff | Diff
Patch (37.34 KB, patch)
2013-05-09 01:36 PDT, Seokju Kwon 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Seokju Kwon 2013-05-09 01:08:38 PDT 
Removed the Memory Instrumentation Code after r148921.


Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:363: WARNING - MemoryAgent.getProcessMemoryDistribution is never defined MemoryAgent.getProcessMemoryDistribution(true,didReceiveMemorySnapshot.bind(profileHeader));

Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:363: WARNING - Property getProcessMemoryDistribution never defined on MemoryAgent
Comment 1 Seokju Kwon 2013-05-09 01:28:48 PDT 
Created attachment 201171 [details]
Patch
Comment 2 Early Warning System Bot 2013-05-09 01:33:44 PDT 
Comment on attachment 201171 [details]
Patch

Attachment 201171 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/300081
Comment 3 Early Warning System Bot 2013-05-09 01:34:35 PDT 
Comment on attachment 201171 [details]
Patch

Attachment 201171 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/418450
Comment 4 Seokju Kwon 2013-05-09 01:36:20 PDT 
Created attachment 201172 [details]
Patch
Comment 5 WebKit Commit Bot 2013-05-09 08:16:17 PDT 
Comment on attachment 201172 [details]
Patch

Clearing flags on attachment: 201172

Committed r149807: <http://trac.webkit.org/changeset/149807>
Comment 6 WebKit Commit Bot 2013-05-09 08:16:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Joseph Pecoraro 2013-05-09 11:20:19 PDT 
Comment on attachment 201172 [details]
Patch

I think there may be some layout tests that can be removed as well.
Comment 8 Seokju Kwon 2013-05-12 20:06:59 PDT 
(In reply to comment #7)
> (From update of attachment 201172 [details])
> I think there may be some layout tests that can be removed as well.

@Joseph Pecoraro Thanks! I will file a new patch for it. :-)