Bug 115843 - [BLACKBERRY]fix regression in Webpage
Summary: [BLACKBERRY]fix regression in Webpage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-08 20:00 PDT by xuefeiren
Modified: 2013-05-09 08:41 PDT (History)
6 users (show)

See Also:

Attachments
Fix regression in WebPage and FrameLoaderClientBlackberry (3.42 KB, patch)
2013-05-08 20:11 PDT, xuefeiren 		mawu: review-
mawu: commit-queue-
Details | Formatted Diff | Diff
Fix regression in WebPage and FrameLoaderClientBlackberry (3.47 KB, patch)
2013-05-08 20:41 PDT, xuefeiren 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description xuefeiren 2013-05-08 20:00:27 PDT 
fix regression StartDownload  in FrameLoaderClientBlackBerry
Comment 1 xuefeiren 2013-05-08 20:11:57 PDT 
Created attachment 201130 [details]
Fix regression in WebPage and FrameLoaderClientBlackberry

Fix regression in WebPage and FrameLoaderClientBlackberry
Comment 2 Mary Wu 2013-05-08 20:16:42 PDT 
Comment on attachment 201130 [details]
Fix regression in WebPage and FrameLoaderClientBlackberry

View in context: https://bugs.webkit.org/attachment.cgi?id=201130&action=review

> Source/WebKit/blackberry/ChangeLog:5
> +        Reviewed by Mary Wu.

don't put here, it's internally review

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1192
> +    requestCopy.setTargetType(BlackBerry::Platform::NetworkRequest::TargetIsDownload);/*forceDownload=true*/

obvious mistake, you use NetworkRequest to initiate ResourceRequest?
Comment 3 xuefeiren 2013-05-08 20:41:14 PDT 
Created attachment 201131 [details]
Fix regression in WebPage and FrameLoaderClientBlackberry

Fix regression in WebPage and FrameLoaderClientBlackberry
Comment 4 Mary Wu 2013-05-08 23:13:51 PDT 
(In reply to comment #3)
> Created an attachment (id=201131) [details]
> Fix regression in WebPage and FrameLoaderClientBlackberry
> 
> Fix regression in WebPage and FrameLoaderClientBlackberry

ok
Comment 5 Benjamin Poulain 2013-05-09 01:54:44 PDT 
Please do not r- patches if you are not a reviewer.
Comment 6 Rob Buis 2013-05-09 08:11:49 PDT 
Comment on attachment 201131 [details]
Fix regression in WebPage and FrameLoaderClientBlackberry

Ok.
Comment 7 WebKit Commit Bot 2013-05-09 08:41:28 PDT 
Comment on attachment 201131 [details]
Fix regression in WebPage and FrameLoaderClientBlackberry

Clearing flags on attachment: 201131

Committed r149810: <http://trac.webkit.org/changeset/149810>
Comment 8 WebKit Commit Bot 2013-05-09 08:41:30 PDT 
All reviewed patches have been landed.  Closing bug.