Bug 115830 - HTMLEmbedElement::updateWidget should not schedule, load, or cancel a page load
Summary: HTMLEmbedElement::updateWidget should not schedule, load, or cancel a page load
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-08 16:49 PDT by Ryosuke Niwa
Modified: 2022-07-01 11:35 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-05-08 16:49:12 PDT 
We shouldn’t do things like:

    #1 0x7f26f14cf151 in WebCore::FrameLoader::completed() third_party/WebKit/Source/WebCore/loader/FrameLoader.cpp:1084
    #2 0x7f26f14ceada in WebCore::FrameLoader::checkCompleted() third_party/WebKit/Source/WebCore/loader/FrameLoader.cpp:782
    #3 0x7f26f157a31f in WebCore::CachedResourceLoader::loadDone(WebCore::CachedResource*) third_party/WebKit/Source/WebCore/loader/cache/CachedResourceLoader.cpp:748
    #4 0x7f26f153e54a in WebCore::SubresourceLoader::releaseResources() third_party/WebKit/Source/WebCore/loader/SubresourceLoader.cpp:322
    #5 0x7f26f1533491 in WebCore::ResourceLoader::cancel(WebCore::ResourceError const&) third_party/WebKit/Source/WebCore/loader/ResourceLoader.cpp:420
    #6 0x7f26f150aa69 in WebCore::MainResourceLoader::cancel(WebCore::ResourceError const&) third_party/WebKit/Source/WebCore/loader/MainResourceLoader.cpp:129
    #7 0x7f26f150a4f3 in WebCore::MainResourceLoader::cancel() third_party/WebKit/Source/WebCore/loader/MainResourceLoader.cpp:111
    #8 0x7f26f14989c8 in WebCore::DocumentLoader::stopLoading() third_party/WebKit/Source/WebCore/loader/DocumentLoader.cpp:257
    #9 0x7f26f151440c in WebCore::NavigationScheduler::schedule(WTF::PassOwnPtr<WebCore::ScheduledNavigation>) third_party/WebKit/Source/WebCore/loader/NavigationScheduler.cpp:440
    #10 0x7f26f1514cba in WebCore::NavigationScheduler::scheduleLocationChange(WebCore::SecurityOrigin*, WTF::String const&, WTF::String const&, bool, bool) third_party/WebKit/Source/WebCore/loader/NavigationScheduler.cpp:361
    #11 0x7f26f15361de in WebCore::SubframeLoader::loadOrRedirectSubframe(WebCore::HTMLFrameOwnerElement*, WebCore::KURL const&, WTF::AtomicString const&, bool, bool) third_party/WebKit/Source/WebCore/loader/SubframeLoader.cpp:339
    #12 0x7f26f153878b in WebCore::SubframeLoader::requestObject(WebCore::HTMLPlugInImageElement*, WTF::String const&, WTF::AtomicString const&, WTF::String const&, WTF::Vector<WTF::String, 0ul> const&, WTF::Vector<WTF::String, 0ul> const&) third_party/WebKit/Source/WebCore/loader/SubframeLoader.cpp:242
    #13 0x7f26f5dcec01 in WebCore::HTMLEmbedElement::updateWidget(WebCore::PluginCreationOption) third_party/WebKit/Source/WebCore/html/HTMLEmbedElement.cpp:173

Ideally, these things are done asynchronously in some queue instead.
Comment 1 Brady Eidson 2013-05-08 23:01:39 PDT 
(In reply to comment #0)
> We shouldn’t do things like: <this particular loading logic>

Have you checked the spec(s) by any chance?  (I haven't yet)
Comment 2 Alexey Proskuryakov 2022-07-01 11:35:20 PDT 
Mass closing plug-in bugs, as plug-in support has been removed from WebKit.

Please comment and/or reopen if this still affects WebKit in some way.