Bug 115821 - TextTrackCue should support empty content
Summary: TextTrackCue should support empty content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-08 13:09 PDT by Eric Carlson
Modified: 2013-05-08 13:52 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (6.29 KB, patch)
2013-05-08 13:19 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-05-08 13:09:11 PDT
'new TextTrackCue(start, end, "")' is valid but it currently creates a cue that causes WebKit to crash. 

Don't do that.
Comment 1 Radar WebKit Bug Importer 2013-05-08 13:09:42 PDT
<rdar://problem/13841113>
Comment 2 Eric Carlson 2013-05-08 13:19:57 PDT
Created attachment 201101 [details]
Proposed patch
Comment 3 Jer Noble 2013-05-08 13:25:56 PDT
Comment on attachment 201101 [details]
Proposed patch

Null checks are awesome.
Comment 4 WebKit Commit Bot 2013-05-08 13:52:43 PDT
Comment on attachment 201101 [details]
Proposed patch

Clearing flags on attachment: 201101

Committed r149766: <http://trac.webkit.org/changeset/149766>
Comment 5 WebKit Commit Bot 2013-05-08 13:52:45 PDT
All reviewed patches have been landed.  Closing bug.