Bug 115816 - new-run-webkit-websocketserver doesn't work after Chromium removal
Summary: new-run-webkit-websocketserver doesn't work after Chromium removal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-08 12:10 PDT by Ryosuke Niwa
Modified: 2013-05-08 12:25 PDT (History)
5 users (show)

See Also:

Attachments
Fixes the bug (1.89 KB, patch)
2013-05-08 12:11 PDT, Ryosuke Niwa 		joepeck: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-05-08 12:10:44 PDT 
new-run-webkit-websocketserver doesn't work after Chromium removal
Comment 1 Ryosuke Niwa 2013-05-08 12:11:11 PDT 
Created attachment 201092 [details]
Fixes the bug
Comment 2 Joseph Pecoraro 2013-05-08 12:16:01 PDT 
Comment on attachment 201092 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=201092&action=review

Looks good to me! Thanks.

> Tools/Scripts/new-run-webkit-websocketserver:38
> +from webkitpy.port import platform_options

Alphabetical order? Or does that style not matter in py.

> Tools/Scripts/new-run-webkit-websocketserver:106
>      # FIXME: Make this work with other ports as well.

Seems like you can remove the FIXME now.
Comment 3 Ryosuke Niwa 2013-05-08 12:25:36 PDT 
Committed r149757: <http://trac.webkit.org/changeset/149757>