Bug 115815 - Add missing USE(TEXTURE_MAPPER) guards
Summary: Add missing USE(TEXTURE_MAPPER) guards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-08 12:02 PDT by Rob Buis
Modified: 2013-05-09 09:13 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.81 KB, patch)
2013-05-08 12:26 PDT, Rob Buis 		benjamin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2013-05-08 12:02:43 PDT 
Note that BB port does not use texmap at all, so some parts of it must lack USE(TEXTURE_MAPPER) guards.
Comment 1 Rob Buis 2013-05-08 12:26:34 PDT 
Created attachment 201095 [details]
Patch
Comment 2 Benjamin Poulain 2013-05-09 02:02:47 PDT 
Comment on attachment 201095 [details]
Patch

Ok in principle but fix the style before landing.

In cpp files, I think it should be (please check):
    #include config
    #include mainheader

    #if Foobar
    [...]

--
I also suggest you to comment the #endif with the condition when it makes sense.
Comment 3 Rob Buis 2013-05-09 08:50:06 PDT 
(In reply to comment #2)
> (From update of attachment 201095 [details])
> Ok in principle but fix the style before landing.
> 
> In cpp files, I think it should be (please check):
>     #include config
>     #include mainheader
> 
>     #if Foobar
>     [...]

I talked it over with Noam. We do not want to change the current structure of this too much for now, Noam could look at it once he is unblocked.

> --
> I also suggest you to comment the #endif with the condition when it makes sense.

Not a big fan of this, they can go stale, I left the patch as-is.
Thanks for the review btw!
Comment 4 Rob Buis 2013-05-09 09:13:41 PDT 
Committed r149813: <http://trac.webkit.org/changeset/149813>