RESOLVED FIXED115802
Allow blank spaces before colon (:) on CSS variable definition 
https://bugs.webkit.org/show_bug.cgi?id=115802
Summary Allow blank spaces before colon (:) on CSS variable definition
Sergio Villar Senin
Reported 2013-05-08 07:21:08 PDT
Something like: :root { -webkit-var-mycolor : red; } won't define a new CSS variable "mycolor" because there is a space before the colon.
Attachments
Patch (3.53 KB, patch)
2013-05-08 07:25 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (3.53 KB, patch)
2013-05-08 07:27 PDT, Sergio Villar Senin 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2013-05-08 07:25:52 PDT
Created attachment 201071 [details] Patch
Sergio Villar Senin
Comment 2 2013-05-08 07:27:04 PDT
Created attachment 201072 [details] Patch
Darin Adler
Comment 3 2013-05-08 07:30:18 PDT
Comment on attachment 201072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201072&action=review r=me, but please do this without adding a new production > Source/WebCore/css/CSSGrammar.y.in:1623 > - VAR_DEFINITION ':' maybe_space expr prio { > + var_definition ':' maybe_space expr prio { > #if ENABLE_CSS_VARIABLES > parser->storeVariableDeclaration($1, parser->sinkFloatingValueList($4), $5); > $$ = true; It’s unnecessary to add a new production for this. Instead you should just add the maybe_space to this production, and change $4 to $5 and $5 to $6.
Sergio Villar Senin
Comment 4 2013-05-08 08:18:37 PDT
Committed r149740: <http://trac.webkit.org/changeset/149740>
Note You need to log in before you can comment on or make changes to this bug.