Bug 115795 - [Qt][Mac] WRT build broken after r149692
Summary: [Qt][Mac] WRT build broken after r149692
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 42324
  Show dependency treegraph
 
Reported: 2013-05-08 05:02 PDT by Zoltan Arvai
Modified: 2013-05-08 05:29 PDT (History)
7 users (show)

See Also:


Attachments
Speculative fix (1.02 KB, patch)
2013-05-08 05:08 PDT, Zoltan Arvai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Arvai 2013-05-08 05:02:58 PDT
In r149692 DOMAsWebArchive added to WTR. 


In Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 

#if USE(CF) 
#include "WebArchiveDumpSupport.h" 
#endif

section is true on Qt Mac, but not true on other Qt port.

If we want DOMAsWebArchive feature on Qt Mac we should add it to Target.pri. Probably it's better to disable it by changing "#if USE(CF)" to "#if USE(CF) && !PLATFORM(Qt)" to get the same WTR on Qt Linux and Qt Mac.

What is your opinion about that?
Comment 1 Zoltan Arvai 2013-05-08 05:08:17 PDT
Created attachment 201060 [details]
Speculative fix

Exclude Qt Mac from include.
Comment 2 Andras Becsi 2013-05-08 05:24:48 PDT
(In reply to comment #1)
> Created an attachment (id=201060) [details]
> Speculative fix
> 
> Exclude Qt Mac from include.

I just landed the fix for that, sorry :)

http://trac.webkit.org/changeset/149731
Comment 3 Zoltan Arvai 2013-05-08 05:27:43 PDT
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=201060) [details] [details]
> > Speculative fix
> > 
> > Exclude Qt Mac from include.
> 
> I just landed the fix for that, sorry :)
> 
> http://trac.webkit.org/changeset/149731


No problem, thanks for fixing it :-)