RESOLVED FIXED 115795
[Qt][Mac] WRT build broken after r149692 
https://bugs.webkit.org/show_bug.cgi?id=115795
Summary [Qt][Mac] WRT build broken after r149692
Zoltan Arvai
Reported 2013-05-08 05:02:58 PDT
In r149692 DOMAsWebArchive added to WTR. In Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp #if USE(CF) #include "WebArchiveDumpSupport.h" #endif section is true on Qt Mac, but not true on other Qt port. If we want DOMAsWebArchive feature on Qt Mac we should add it to Target.pri. Probably it's better to disable it by changing "#if USE(CF)" to "#if USE(CF) && !PLATFORM(Qt)" to get the same WTR on Qt Linux and Qt Mac. What is your opinion about that?
Attachments
Speculative fix (1.02 KB, patch)
2013-05-08 05:08 PDT, Zoltan Arvai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Arvai
Comment 1 2013-05-08 05:08:17 PDT
Created attachment 201060 [details] Speculative fix Exclude Qt Mac from include.
Andras Becsi
Comment 2 2013-05-08 05:24:48 PDT
(In reply to comment #1) > Created an attachment (id=201060) [details] > Speculative fix > > Exclude Qt Mac from include. I just landed the fix for that, sorry :) http://trac.webkit.org/changeset/149731
Zoltan Arvai
Comment 3 2013-05-08 05:27:43 PDT
(In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=201060) [details] [details] > > Speculative fix > > > > Exclude Qt Mac from include. > > I just landed the fix for that, sorry :) > > http://trac.webkit.org/changeset/149731 No problem, thanks for fixing it :-)
Note You need to log in before you can comment on or make changes to this bug.