Bug 115775 – Make CanvasStyle a plain object instead of an RefCounted object

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

Make CanvasStyle a plain object instead of an RefCounted object

[Benjamin Poulain]

Created attachment 201026 [details]
Patch

[WebKit Commit Bot]

Attachment 201026 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.h', u'Source/WebCore/html/canvas/CanvasStyle.cpp', u'Source/WebCore/html/canvas/CanvasStyle.h']" exit_code: 1
Source/WebCore/html/canvas/CanvasStyle.h:76:  Missing spaces around &&  [whitespace/operators] [3]
Source/WebCore/html/canvas/CanvasStyle.h:77:  Missing spaces around &&  [whitespace/operators] [3]
Source/WebCore/html/canvas/CanvasStyle.h:81:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 201026 [details]
Patch

Attachment 201026 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/310115

[Early Warning System Bot]

Comment on attachment 201026 [details]
Patch

Attachment 201026 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/424039

[kov's GTK+ EWS bot]

Comment on attachment 201026 [details]
Patch

Attachment 201026 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/377533

[EFL EWS Bot]

Comment on attachment 201026 [details]
Patch

Attachment 201026 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/398075

[EFL EWS Bot]

Comment on attachment 201026 [details]
Patch

Attachment 201026 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/377534

[Build Bot]

Comment on attachment 201026 [details]
Patch

Attachment 201026 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/302084

[Benjamin Poulain]

Created attachment 201029 [details]
Patch

[WebKit Commit Bot]

Attachment 201029 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.h', u'Source/WebCore/html/canvas/CanvasStyle.cpp', u'Source/WebCore/html/canvas/CanvasStyle.h']" exit_code: 1
Source/WebCore/html/canvas/CanvasStyle.h:76:  Missing spaces around &&  [whitespace/operators] [3]
Source/WebCore/html/canvas/CanvasStyle.h:77:  Missing spaces around &&  [whitespace/operators] [3]
Source/WebCore/html/canvas/CanvasStyle.h:81:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 201029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201029&action=review

r=me

> Source/WebCore/html/canvas/CanvasStyle.h:46
> +        CanvasStyle(RGBA32);

I'd prefer this to be explicit.

> Source/WebCore/html/canvas/CanvasStyle.h:51
> +        CanvasStyle(PassRefPtr<CanvasGradient>);
> +        CanvasStyle(PassRefPtr<CanvasPattern>);

Ditto for these.

> Source/WebCore/html/canvas/CanvasStyle.h:111
> +        Type m_type;

I'd make this member const, as it should never change after construction.

[Benjamin Poulain]

Created attachment 201105 [details]
Patch

[WebKit Commit Bot]

Attachment 201105 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.h', u'Source/WebCore/html/canvas/CanvasStyle.cpp', u'Source/WebCore/html/canvas/CanvasStyle.h']" exit_code: 1
Source/WebCore/html/canvas/CanvasStyle.h:76:  Missing spaces around &&  [whitespace/operators] [3]
Source/WebCore/html/canvas/CanvasStyle.h:77:  Missing spaces around &&  [whitespace/operators] [3]
Source/WebCore/html/canvas/CanvasStyle.h:81:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Benjamin Poulain]

Committed r149928: <http://trac.webkit.org/changeset/149928>